webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tsnet: fix advertiseService dropping existing services

Browse Source 
AppendTo returns the new slice but the result was discarded,
so only the newly added service was advertised.

Signed-off-by: Evan Champion <110177090+evan314159@users.noreply.github.com>
This commit is contained in:
Evan Champion
2026-03-29 04:57:58 +08:00
committed by Harry Harpham
parent 4c0f488389
commit 99f8039101
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tsnet/tsnet.go
+1 -1
View File
@@ -1574,7 +1574,7 @@ func (s *Server) advertiseService(name tailcfg.ServiceName) error {
advertised := s.lb.Prefs().AdvertiseServices() advertised := s.lb.Prefs().AdvertiseServices()
if !views.SliceContains(advertised, name.String()) { if !views.SliceContains(advertised, name.String()) {
newAdvertised := make([]string, 0, advertised.Len()+1) newAdvertised := make([]string, 0, advertised.Len()+1)
advertised.AppendTo(newAdvertised) newAdvertised = advertised.AppendTo(newAdvertised)
newAdvertised = append(newAdvertised, name.String()) newAdvertised = append(newAdvertised, name.String())
_, err := s.lb.EditPrefs(&ipn.MaskedPrefs{ _, err := s.lb.EditPrefs(&ipn.MaskedPrefs{
AdvertiseServicesSet: true, AdvertiseServicesSet: true,