From 99f8039101036857f088c8b72cac365f80219a27 Mon Sep 17 00:00:00 2001 From: Evan Champion <110177090+evan314159@users.noreply.github.com> Date: Sun, 29 Mar 2026 04:57:58 +0800 Subject: [PATCH] tsnet: fix advertiseService dropping existing services AppendTo returns the new slice but the result was discarded, so only the newly added service was advertised. Signed-off-by: Evan Champion <110177090+evan314159@users.noreply.github.com> --- tsnet/tsnet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tsnet/tsnet.go b/tsnet/tsnet.go index 499c1e0b5..962cd8ecb 100644 --- a/tsnet/tsnet.go +++ b/tsnet/tsnet.go @@ -1574,7 +1574,7 @@ func (s *Server) advertiseService(name tailcfg.ServiceName) error { advertised := s.lb.Prefs().AdvertiseServices() if !views.SliceContains(advertised, name.String()) { newAdvertised := make([]string, 0, advertised.Len()+1) - advertised.AppendTo(newAdvertised) + newAdvertised = advertised.AppendTo(newAdvertised) newAdvertised = append(newAdvertised, name.String()) _, err := s.lb.EditPrefs(&ipn.MaskedPrefs{ AdvertiseServicesSet: true,