tsnet: fix advertiseService dropping existing services
AppendTo returns the new slice but the result was discarded, so only the newly added service was advertised. Signed-off-by: Evan Champion <110177090+evan314159@users.noreply.github.com>
This commit is contained in:
committed by
Harry Harpham
parent
4c0f488389
commit
99f8039101
+1
-1
@@ -1574,7 +1574,7 @@ func (s *Server) advertiseService(name tailcfg.ServiceName) error {
|
||||
advertised := s.lb.Prefs().AdvertiseServices()
|
||||
if !views.SliceContains(advertised, name.String()) {
|
||||
newAdvertised := make([]string, 0, advertised.Len()+1)
|
||||
advertised.AppendTo(newAdvertised)
|
||||
newAdvertised = advertised.AppendTo(newAdvertised)
|
||||
newAdvertised = append(newAdvertised, name.String())
|
||||
_, err := s.lb.EditPrefs(&ipn.MaskedPrefs{
|
||||
AdvertiseServicesSet: true,
|
||||
|
||||
Reference in New Issue
Block a user