webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,419 Commits 3 Branches 0 Tags
dc32b4695c2e195c3380a23d2cd26e0d24004b6b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
David Anderson a3b15bdf7e .github: remove verbose issue templates, add triage label. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-05-06 19:14:19 -07:00
David AndersonandDave Anderson 5bd38b10b4 net/dns: log the correct error when NM Reapply fails. 
Found while debugging #1870.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-05-06 16:02:09 -07:00
David AndersonandDave Anderson 7d16c8228b net/dns: set IPv4 auto mode in NM, so it lets us set DNS. 
Part of #1870.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-05-06 16:02:09 -07:00
David AndersonandDave Anderson 77e2375501 net/dns: don't try to configure LLMNR or mdns in NetworkManager. 
Fixes #1870.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-05-06 16:02:09 -07:00
David Anderson bf5fc8edda go.mod: update wireguard-go. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-29 16:36:55 -07:00
David AndersonandDave Anderson 1d7e7b49eb ipn/ipnlocal: be authoritative for the entire MagicDNS record tree. 
With this change, shared node names resolve correctly on split DNS-supporting
operating systems.

Fixes tailscale/corp#1706

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-29 16:06:01 -07:00
David Anderson bf9ef1ca27 net/dns: stop NetworkManager breaking v6 connectivity when setting DNS. 
Tentative fix for #1699

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-29 12:25:47 -07:00
David Anderson 72b6d98298 net/interfaces: return all Tailscale addresses from Tailscale(). 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-29 12:25:47 -07:00
David Anderson 306a094d4b ipn/ipnlocal: remove IPv6 records from MagicDNS. 
Fixes #1813.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-28 01:01:56 -07:00
David Anderson 44c2b7dc79 net/dns: on windows, skip site-local v6 resolvers. 
Further refinement for tailscale/corp#1662.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-27 18:24:54 -07:00
David AndersonandDave Anderson 97d2fa2f56 net/dns: work around WSL DNS implementation flaws. 
Fixes tailscale/corp#1662

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-26 16:54:50 -07:00
David Anderson f6b7d08aea net/dns: work around new NetworkManager in other selection paths. 
Further bits of #1788

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-23 22:09:00 -07:00
David Anderson 25ce9885a2 net/dns: don't use NM+resolved for NM >=1.26.6. 
NetworkManager fixed the bug that forced us to use NetworkManager
if it's programming systemd-resolved, and in the same release also
made NetworkManager ignore DNS settings provided for unmanaged
interfaces... Which breaks what we used to do. So, with versions
1.26.6 and above, we MUST NOT use NetworkManager to indirectly
program systemd-resolved, but thankfully we can talk to resolved
directly and get the right outcome.

Fixes #1788

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-23 21:13:19 -07:00
David Anderson 31f81b782e util/cmpver: move into OSS from corp repo. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-23 20:55:45 -07:00
David AndersonandDave Anderson 30f5d706a1 net/dns/resolver: remove unnecessary/racy WaitGroup. 
Fixes #1663

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-22 19:17:37 -07:00
David AndersonandDave Anderson 30629c430a cmd/tailscale/cli: don't force an interactive login on --reset. 
Fixes #1778

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-22 15:53:50 -07:00
David Anderson 36d030cc36 ipn/ipnlocal: use fallback default DNS whenever exit nodes are on. 
Fixes #1625

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-22 15:24:18 -07:00
David Anderson 67ba6aa9fd cmd/tailscale/cli: fix typo in ExitNodeID mapping. 
Prevented turning off exit nodes.

Fixes #1777

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-22 14:55:29 -07:00
David Anderson 6fd9e28bd0 ipn/ipnlocal: add arpa suffixes to MagicDNS for reverse lookups. 
This used to not be necessary, because MagicDNS always did full proxying.
But with split DNS, we need to know which names to route to our resolver,
otherwise reverse lookups break.

This captures the entire CGNAT range, as well as our Tailscale ULA.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 18:05:17 -07:00
David Anderson 89c81c26c5 net/dns: fix resolved match domains when no nameservers are provided. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 17:10:39 -07:00
David Anderson 4be26b269f net/dns: correctly capture all traffic in non-split configs. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 16:57:46 -07:00
David Anderson ca283ac899 net/dns: remove config in openresolv when given an empty DNS config. 
Part of #1720.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 16:19:34 -07:00
David Anderson 48d4f14652 ipn/ipnlocal: only set authoritative domains when using MagicDNS. 
Otherwise, the existence of authoritative domains forces full
DNS proxying even when no other DNS config is present.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 15:52:19 -07:00
David Anderson 53213114ec net/dns: make debian_resolvconf correctly clear DNS configs. 
More of #1720.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 15:51:14 -07:00
David Anderson 3b1ab78954 net/dns: restore resolv.conf when given an empty config in directManager. 
Fixes #1720.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 15:14:40 -07:00
David Anderson 158328ba24 net/dns: remove ForceSplitDNSForTesting. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 12:50:08 -07:00
David AndersonandDave Anderson 1e5c608fae ipn/ipnlocal: plumb fallback DNS in as a workaround for split DNS issues. 
Cause of #1743.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 12:49:48 -07:00
David AndersonandDave Anderson 28ba20d733 tailcfg: add FallbackResolvers to DNSConfig. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-20 12:49:48 -07:00
David Anderson 7055f870f8 control/controlclient: only use a single DNS label as the hostname. 
Fixes #971

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-15 17:08:58 -07:00
David Anderson bb0710d51d net/dns: add debugging traces to DNS manager selection on linux. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-14 15:52:41 -07:00
David Anderson 4b70c7b717 net/dns: fix inverted test for NetworkManager. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-14 15:52:22 -07:00
David Anderson 4849a4d3c8 net/dns: error out on linux if /etc/resolv.conf can't be read. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-14 15:35:32 -07:00
David Anderson 1f9b73a531 net/dns: fix freebsd DNS manager selection. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-14 15:34:59 -07:00
David Anderson 84bd50329a net/dns: fix staticheck. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-13 17:28:37 -07:00
David Anderson d6bb11b5bf net/dns: implement correct manager detection on linux. 
Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-13 17:19:00 -07:00
David Anderson 9ef932517b net/dns: fix NM's GetBaseConfig when no configs exist. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-13 17:19:00 -07:00
David Anderson fe3b1ab747 net/dns: refactor dbus connection setup in resolved manager. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-13 17:19:00 -07:00
David Anderson 854d5d36a1 net/dns: return error from NewOSManager, use it to initialize NM. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-12 15:51:37 -07:00
David AndersonandDave Anderson 9aa33b43e6 net/dns: support split and unsplit DNS in NetworkManager. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-12 14:34:08 -07:00
David Anderson 87eb8384f5 net/dns: fix up NetworkManager configurator a bit. 
Clear LLMNR and mdns flags, update reasoning for our settings,
and set our override priority harder than before when we want
to be primary resolver.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-11 23:19:50 -07:00
David Anderson 3d81e6260b net/dns: set resolved DefaultRoute setting according to split-dns mode. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-11 20:53:28 -07:00
David Anderson cca230cc23 net/dns: fix staticcheck errors. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-11 20:53:28 -07:00
David Anderson a7340c2015 net/dns: support split DNS in systemd-resolved. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-11 18:14:23 -07:00
David Anderson 84430cdfa1 net/dns: improve NetworkManager detection, using more DBus. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-11 15:22:06 -07:00
David Anderson 9a48bac8ad net/dns: rename resolvconf.go to debian_resolvconf.go. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 23:31:14 -07:00
David Anderson 9831f1b183 net/dns: also include 'tail' and 'base' files when fixing up resolv.conf. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 23:01:11 -07:00
David Anderson e43afe9140 net/dns: implement prior config reading for debian resolvconf. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 22:37:13 -07:00
David Anderson 143e5dd087 net/dns: rename script variable. 
Debian resolvconf is not legacy, it's alive and well,
just historically before the other implementations.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 21:28:27 -07:00
David Anderson 55b39fa945 net/dns: add documentation to openresolv's config fetch. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 20:21:05 -07:00
David Anderson 61b361bac0 net/dns: teach the openresolv manager to read DNS config. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 19:37:11 -07:00
David Anderson 19eca34f47 wgengine/router: fix FreeBSD configuration failure on the v6 /48. 
On FreeBSD, we add the interface IP as a /48 to work around a kernel
bug, so we mustn't then try to add a /48 route to the Tailscale ULA,
since that will fail as a dupe.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 19:36:26 -07:00
David Anderson 58760f7b82 net/dns: split resolvconfManager into a debian and an openresolv manager. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 18:55:05 -07:00
David AndersonandDave Anderson 5480189313 net/dns: implement a DNS override workaround for legacy resolvconf. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 17:58:13 -07:00
David AndersonandDave Anderson 1a371b93be util/dnsname: add FQDN type, use throughout codebase. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-10 17:58:13 -07:00
David Anderson e638a4d86b net/dns: make directManager support split DNS, and work in sandboxes. 
Fixes #1495, #683.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-09 02:52:21 -07:00
David Anderson 2685260ba1 net/dns: add temporary fallback to quad-9 resolver for split-DNS testing. 
This allows split-DNS configurations to not break clients on OSes that
haven't yet been ported to understand split DNS, by falling back to quad-9
as a global resolver when handed an "impossible to implement"
split-DNS config.

Part of #953. Needs to be removed before shipping 1.8.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 23:26:22 -07:00
David Anderson b9e194c14b net/dns: add missing FQDN qualification. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 23:07:16 -07:00
David Anderson b74a8994ca net/dns: make FQDN dot style consistent in more places. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 22:03:32 -07:00
David Anderson 2f398106e2 ipn/ipnlocal: allow setting MagicDNS without DefaultResolvers. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 16:23:33 -07:00
David AndersonandDave Anderson fad21af01c tailcfg: add DNS routes and advanced resolver config. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 15:29:08 -07:00
David Anderson 6def647514 net/dns/resolver: don't avoid tailscale routes for DNS forwarding. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-08 12:20:42 -07:00
David AndersonandDave Anderson 4a64d2a603 net/dns: some post-review cleanups. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson 720c1ad0f0 net/dns: insert OS base config when emulating split DNS. 
Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson e560be6443 net/dns: sort matchDomains to avoid test flake. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson 68f76e9aa1 net/dns: add GetBaseConfig to OSConfigurator interface. 
Part of #953, required to make split DNS work on more basic
platforms.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson fe9cd61d71 net/dns: add tests for DNS config generation. 
Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson 0ba6d03768 net/dns/resolver: add a test helper to get at the resolver config. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David AndersonandDave Anderson da4cc8bbb4 net/dns: handle all possible translations of high-level DNS config. 
With this change, all OSes can sort-of do split DNS, except that the
default upstream is hardcoded to 8.8.8.8 pending further plumbing.
Additionally, Windows 8-10 can do split DNS fully correctly, without
the 8.8.8.8 hack.

Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-07 15:40:31 -07:00
David Anderson e0e677a8f6 net/dns: split out search domains and match domains in OSConfig. 
It seems that all the setups that support split DNS understand
this distinction, and it's an important one when translating
high-level configuration.

Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-06 15:27:09 -07:00
David Anderson a8dcda9c9a net/dns: start of compat hacks for Windows 7. 
Correctly reports that Win7 cannot do split DNS, and has a helper to
discover the "base" resolvers for the system.

Part of #953

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-06 15:27:09 -07:00
David AndersonandDave Anderson 3e915ac783 net/dns: implement OS-level split DNS for Windows. 
Part of #953.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 22:53:10 -07:00
David AndersonandDave Anderson c16a926bf2 net/dns: set OSConfig.Primary. 
OS implementations are going to support split DNS soon.
Until they're all in place, hardcode Primary=true to get
the old behavior.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 22:53:10 -07:00
David AndersonandDave Anderson bc4381447f net/tstun: return the real interface name at device creation. 
This is usually the same as the requested interface, but on some
unixes can vary based on device number allocation, and on Windows
it's the GUID instead of the pretty name, since everything relating
to configuration wants the GUID.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 22:53:10 -07:00
David Anderson de6dc4c510 net/dns: add a Primary field to OSConfig. 
Currently ignored.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 13:05:47 -07:00
David AndersonandDave Anderson b2a597b288 net/dns: rename Set to SetDNS in OSConfigurator. 
wgengine/router.CallbackRouter needs to support both the Router
and OSConfigurator interfaces, so the setters can't both be called
Set.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson 7d84ee6c98 net/dns: unify the OS manager and internal resolver. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson 1bf91c8123 net/dns/resolver: remove unused err return value. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson 6a206fd0fb net/dns: rename impl to os. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson c4530971db net/dns/resolver: remove leftover debug print. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson f007a9dd6b health: add DNS subsystem and plumb errors in. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David AndersonandDave Anderson 4c61ebacf4 wgengine: move DNS configuration out of wgengine/router. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-05 10:55:35 -07:00
David Anderson 748670f1e9 net/dns: fix typo in docstring. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 18:44:02 -07:00
David Anderson 27a1a2976a wgengine/router: add a CallbackRouter shim. 
The shim implements both network and DNS configurators,
and feeds both into a single callback that receives
both configs.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 18:43:24 -07:00
David Anderson f89dc1c903 ipn/ipnlocal: don't install any magicdns names if not proxying. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 14:24:47 -07:00
David Anderson a39d2403bc net/dns: disable NetworkManager and resolved configurators temporarily. 
They need some rework to do the right thing, in the meantime the direct
and resolvconf managers will work out.

The resolved implementation was never selected due to control-side settings.
The networkmanager implementation mostly doesn't get selected due to
unforeseen interactions with `resolvconf` on many platforms.
Both implementations also need rework to support the various routing modes
they're capable of.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 02:41:33 -07:00
David Anderson befd8e4e68 net/dns: replace managerImpl with OSConfigurator in code. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 02:34:40 -07:00
David Anderson 077d4dc8c7 net/dns: add an OSConfigurator interface. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 01:49:17 -07:00
David AndersonandDave Anderson 6ad44f9fdf wgengine: take in dns.Config, split out to resolver.Config and dns.OSConfig. 
Stepping stone towards having the DNS package handle the config splitting.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 00:59:44 -07:00
David AndersonandDave Anderson 2edb57dbf1 net/dns: add new Config that captures tailscale+OS DNS config. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 00:59:44 -07:00
David AndersonandDave Anderson 8af9d770cf net/dns: rename Config to OSConfig. 
Making way for a new higher level config struct.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-02 00:59:44 -07:00
David Anderson fcfc0d3a08 net/dns: remove ManagerConfig, pass relevant args directly. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 23:26:52 -07:00
David Anderson 0ca04f1e01 net/dns: put noop.go back, limit with build tags for staticcheck. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 23:14:13 -07:00
David Anderson 95470c3448 net/dns: remove Cleanup manager parameter. 
It's only use to skip some optional initialization during cleanup,
but that work is very minor anyway, and about to change drastically.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 23:06:56 -07:00
David Anderson cf361bb9b1 net/dns: remove PerDomain from Config. 
It's currently unused, and no longer makes sense with the upcoming
DNS infrastructure. Keep it in tailcfg for now, since we need protocol
compat for a bit longer.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 22:55:44 -07:00
David Anderson f77ba75d6c wgengine/router: move DNS cleanup into the DNS package. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 22:35:34 -07:00
David Anderson 15875ccc63 wgengine/router: don't store unused tunname on windows. 2021-04-01 22:28:24 -07:00
David Anderson 9f105d3968 net/dns/resolver: teach the forwarder to do per-domain routing. 
Given a DNS route map, the forwarder selects the right set of
upstreams for a given name.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 19:42:48 -07:00
David Anderson 90f82b6946 net/dns/resolver: add live reconfig, plumb through to ipnlocal. 
The resolver still only supports a single upstream config, and
ipn/wgengine still have to split up the DNS config, but this moves
closer to unifying the DNS configs.

As a handy side-effect of the refactor, IPv6 MagicDNS records exist
now.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-04-01 01:44:03 -07:00
David Anderson caeafc4a32 net/dns/resolver: fix package docstring. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-03-31 23:42:28 -07:00
David Anderson dbe4f6f42d net/dns/resolver: unexport Resolve and ResolveReverse. 
They're only used internally and in tests, and have surprising
semantics in that they only resolve MagicDNS names, not upstream
resolver queries.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-03-31 23:35:26 -07:00