webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,822 Commits 3 Branches 0 Tags
38dc6fe75879e11c25ad83e7c17dabc35ef3b37d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Brad Fitzpatrick 38dc6fe758 cmd/tailscaled, wgengine: remove --fake, replace with netstack 
And add a --socks5-server flag.

And fix a race in SOCKS5 replies where the response header was written
concurrently with the copy from the backend.

Co-authored with Naman Sood.

Updates #707
Updates #504

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-03-01 11:09:19 -08:00
Brad FitzpatrickandBrad Fitzpatrick d74cddcc56 wgengine/netstack: add Magic DNS + DNS resolution to SOCKS5 dialing 
Updates #707
Updates #504

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-03-01 09:10:05 -08:00
Brad Fitzpatrick 34188d93d4 wgengine/monitor: start moving interface state accessor into monitor 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-03-01 07:56:06 -08:00
Brad Fitzpatrick 14dc790137 wgengine/monitor: make the darwin link monitor work in the sandbox too 
Previously tailscaled on macOS was running "/sbin/route monitor" as a
child process, but child processes aren't allowed in the Network
Extension / App Store sandbox. Instead, just do what "/sbin/route monitor"
itself does: unix.Socket(unix.AF_ROUTE, unix.SOCK_RAW, 0) and read that.

We also parse it now, but don't do anything with the parsed results yet.

We will over time, as we have with Linux netlink messages over time.

Currently any message is considered a signal to poll and see what changed.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-28 21:14:51 -08:00
Brad Fitzpatrick a55a03d5ff wgengine: let LinkMonitor be passed in to NewUserspaceEngine 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-27 21:55:06 -08:00
Brad Fitzpatrick ee6475a44d wgengine: unify NewUserspaceEngine, NewUserspaceEngineAdvanced 
Also rename EngineConfig to Config to avoid wgengine.EngineConfig
stutter.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-27 21:52:24 -08:00
Brad Fitzpatrick dda03a911e wgengine/monitor: change API to permit multiple independent callbakcks 
Currently it assumes exactly 1 registered callback. This changes it to
support 0, 1, or more than 1.

This is a step towards plumbing wgengine/monitor into more places (and
moving some of wgengine's interface state fetching into monitor in a
later step)

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-27 19:36:52 -08:00
Brad Fitzpatrick 0eea490724 wgengine: also close link monitor on NewUserspaceEngineAdvanced error 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-27 19:11:23 -08:00
Brad Fitzpatrick 2d5db90161 util/winutil: make it actually compile 
Helps to use the right GOOS after refactoring, sigh.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-26 20:52:23 -08:00
Brad Fitzpatrick e98cdbb8b6 util/winutil: add little Windows utility package 
Code from Alex Brainman, split out of another change. I changed it to
a comma-ok return and tweaked the docs a bit.
 2021-02-26 20:42:00 -08:00
Brad FitzpatrickandBrad Fitzpatrick f68431fc02 cmd/derper: add /bootstrap-dns handler 
For option (d) of #1405.

For an HTTPS request of /bootstrap-dns, this returns e.g.:

{
  "log.tailscale.io": [
    "2600:1f14:436:d603:342:4c0d:2df9:191b",
    "34.210.105.16"
  ],
  "login.tailscale.com": [
    "2a05:d014:386:203:f8b4:1d5a:f163:e187",
    "3.121.18.47"
  ]
}

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-26 09:29:28 -08:00
Brad Fitzpatrick c1ae1a3d2d version: bump date 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-26 08:14:35 -08:00
Brad Fitzpatrick 99d67493be cmd/derper: update a link from godoc.org to pkg.go.dev 
Save a redirect.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-26 08:14:15 -08:00
Brad Fitzpatrick 000b80de9d net/interfaces: go idle on macOS when wifi/etc is down, ignore utun* interfaces 
Updates tailscale/corp#1289
Updates tailscale/corp#1367
Updates tailscale/corp#1378
Updates tailscale/felicity#4
 2021-02-25 15:47:29 -08:00
Brad Fitzpatrick 3fd00c4a40 cmd/tailscaled: create /usr/local/bin on macOS install-system-daemon if needed 
Fixes #1400

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-25 12:01:17 -08:00
Brad Fitzpatrick ea3715e3ce wgengine/magicsock: remove TODO about endpoints-over-DERP 
It was done in Tailscale 1.4 with CallMeMaybe disco messages
containing endpoints.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-24 21:34:31 -08:00
Brad FitzpatrickandBrad Fitzpatrick e9e4f1063d wgengine/magicsock: fix discoEndpoint caching bug when a node key changes 
Fixes #1391

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-23 14:39:15 -08:00
Brad FitzpatrickandBrad Fitzpatrick f11952ad7f ipn/ipnserver: fix Windows connection auth regression 
Regression from code movement in d3efe8caf6

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-23 13:27:04 -08:00
Brad FitzpatrickandBrad Fitzpatrick c64bd587ae net/portmapper: add NAT-PMP client, move port mapping service probing 
* move probing out of netcheck into new net/portmapper package
* use PCP ANNOUNCE op codes for PCP discovery, rather than causing
  short-lived (sub-second) side effects with a 1-second-expiring map +
  delete.
* track when we heard things from the router so we can be less wasteful
  in querying the router's port mapping services in the future
* use portmapper from magicsock to map a public port

Fixes #1298
Fixes #1080
Fixes #1001
Updates #864

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-23 09:07:38 -08:00
Brad FitzpatrickandBrad Fitzpatrick 188bb14269 wgengine: consistently close things when NewUserspaceEngineAdvanced errors 
Fixes #1363

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-22 20:39:39 -08:00
Brad FitzpatrickandBrad Fitzpatrick 86d3a6c9a6 Switch to Go 1.16. 
Fixes #1370

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-19 13:18:31 -08:00
Brad Fitzpatrick 9748c5414e portlist: adjust build tags for iOS + Go 1.16 
Updates #943
Updates #1370

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-19 10:03:33 -08:00
Brad Fitzpatrick 826f64e863 cmd/tailscale/cli: add netcheck dev knob TS_DEBUG_NETCHECK_UDP_BIND 2021-02-19 07:48:35 -08:00
Brad Fitzpatrick 7ad3af2141 cmd/tailscale/cli: remove outdated TODO 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-18 15:11:00 -08:00
Brad Fitzpatrick c386496e4f version: bump date 2021-02-18 13:36:48 -08:00
Brad FitzpatrickandBrad Fitzpatrick fd8e070d01 health, control/controlclient, wgengine: report when router unhealthy 
Updates tailscale/corp#1338

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-18 11:48:48 -08:00
Brad FitzpatrickandBrad Fitzpatrick 2d96215d97 wgengine/router: make Linux delRoute idempotent, cidrDiff fail late as possible 
This makes cidrDiff do as much as possible before failing, and makes a
delete of an already-deleted rule be a no-op. We should never do this
ourselves, but other things on the system can, and this should help us
recover a bit.

Also adds the start of root-requiring tests.

TODO: hook into wgengine/monitor and notice when routes are changed
behind our back, and invalidate our routes map and re-read from
kernel (via the ip command) at least on the next reconfig call.

Updates tailscale/corp#1338

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-18 10:36:00 -08:00
Brad FitzpatrickandBrad Fitzpatrick 6a2c6541da net/tshttpproxy: support HTTP proxy environment credentials on Windows too 
and some minor style nits.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-18 08:27:37 -08:00
Brad Fitzpatrick 96a488e37e wgengine/router: simplify func normalizeCIDR using netaddr method 2021-02-17 21:35:33 -08:00
Brad Fitzpatrick 38629b62fc cmd/tailscaled: on darwin, fail early if not root with nicer message 
Don't do it on all platforms, as Linux folk might be playing
container + capability games.
 2021-02-17 15:45:50 -08:00
Brad Fitzpatrick d98ef5699d wgengine/filter: remove redundant code 
no generated code change.
 2021-02-17 09:11:28 -08:00
Brad Fitzpatrick 7038c09bc9 ipn/ipnserver: on darwin, let users who are admins use CLI without sudo 
Tangentially related to #987, #177, #594, #925, #505

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-16 21:09:27 -08:00
Brad Fitzpatrick d3efe8caf6 safesocket, ipn/ipnserver: look up peer creds on Darwin 
And open up socket permissions like Linux, now that we know who
connections are from.

This uses the new inet.af/peercred that supports Linux and Darwin at
the moment.

Fixes #1347
Fixes #1348

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-16 20:38:44 -08:00
Brad FitzpatrickandBrad Fitzpatrick 65815cc1ac wgengine/tsdns: skip test that requires local IPv6 when IPv6 unavailable 
Fixes #1292

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-16 10:50:37 -08:00
Brad Fitzpatrick 4ec01323c1 control/controlclient: note package type in Hostinfo 
Fixes tailscale/corp#440

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-15 13:24:05 -08:00
Brad Fitzpatrick 73552eb32e tailcfg: add Hostinfo.Package 
Updates tailscale/corp#440
 2021-02-15 12:58:56 -08:00
Brad Fitzpatrick dec01ef22b safesocket: make ConnectDefault use paths pkg, fixing tailscaled-on-macOS 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-15 11:33:12 -08:00
Brad Fitzpatrick 7e00100a0a cmd/hello: make whois client work on macOS against GUI client 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-15 11:33:09 -08:00
Brad Fitzpatrick fdac0387a7 ipn/ipnserver, ipn/ipnlocal: move whois handler to new localapi package 2021-02-15 10:46:22 -08:00
Brad Fitzpatrick 36189e2704 wgengine/monitor: prevent shutdown hang in darwin link monitor 2021-02-15 08:59:53 -08:00
Brad Fitzpatrick bbb4631e04 safesocket, wgengine: add some darwin failure diagnostic hints 2021-02-15 08:40:52 -08:00
Brad FitzpatrickandBrad Fitzpatrick f4ae745b0b net/{interfaces,netns}: add some new tests, missed from prior commit 
I meant for these to be part of 52e24aa966.
 2021-02-14 21:18:27 -08:00
Brad Fitzpatrick e923639feb net/interfaces: fix staticcheck error on darwin 2021-02-14 21:17:12 -08:00
Brad Fitzpatrick d7569863b5 cmd/tailscaled: fix up install-system-daemon on darwin, add uninstall too 
Tangentially related to #987, #177, #594, #925, #505
 2021-02-14 21:12:30 -08:00
Brad FitzpatrickandBrad Fitzpatrick 52e24aa966 net/{interfaces,ns}: add tailscaled-mode darwin routing looping prevention 
Fixes #1331

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-14 12:47:47 -08:00
Brad Fitzpatrick 4f7d60ad42 wgengine/monitor: add a darwin implementation for tailscaled mode 
Tangentially related to #987, #177, #594, #925, #505

Motivated by rebooting a launchd-controlled tailscaled and it going
into SetNetworkUp(false) mode immediately because there really is no
network up at system boot, but then it got stuck in that paused state
forever, without a monitor implementation.
 2021-02-13 21:09:27 -08:00
Brad Fitzpatrick 29b028b9c4 cmd/tailscaled: add subcommand on darwin to install+start tailscaled under launchd 
Tangentially related to #987, #177, #594, #925.
 2021-02-13 12:57:49 -08:00
Brad Fitzpatrick 54e108ff4e paths: update some default paths for darwin 2021-02-13 12:10:20 -08:00
Brad Fitzpatrick 20e66c5b92 net/interfaces: reconcile interface filtering with address printing in logs 
The interface.State logging tried to only log interfaces which had
interesting IPs, but the what-is-interesting checks differed between
the code that gathered the interface names to print and the printing
of their addresses.
 2021-02-12 18:42:45 -08:00
Brad Fitzpatrick ca51529b81 derp/derphttp: return nicer errors from Recv on Close 2021-02-12 12:04:16 -08:00
Brad Fitzpatrick 741d654aa3 derp/derphttp: add a context and infoLogger option to RunWatchConnectionLoop 2021-02-12 10:59:11 -08:00
Brad Fitzpatrick be906dabd4 version: bump date 2021-02-11 20:11:00 -08:00
Brad Fitzpatrick 6680976b50 cmd/tailscaled: pick automatic tun device name on darwin 2021-02-11 20:10:07 -08:00
Brad Fitzpatrick 88ab0173a7 wgengine/router: fix BSD router to support multiple local addrs, IPv6 
Fixes #1201
 2021-02-11 19:13:03 -08:00
Brad Fitzpatrick 5378776043 cmd/hello: chop DNS name at first dot 2021-02-11 16:38:26 -08:00
Brad FitzpatrickandBrad Fitzpatrick 917307a90c wgengine/tstun: reply to MagicDNS pings 
Fixes #849

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-11 11:55:38 -08:00
Brad Fitzpatrick 34ffd4f7c6 cmd/hello: serve fake data in dev mode on whois failure 2021-02-11 10:57:08 -08:00
Brad Fitzpatrick de3001bc79 cmd/hello: in dev mode, live reload template 2021-02-11 10:53:33 -08:00
Brad FitzpatrickandBrad Fitzpatrick 1ec64bc94d wgengine/router: add another Windows firewall rule to allow incoming UDP 
Based on @sailorfrag's research.

Fixes #1312

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-10 13:12:17 -08:00
Brad FitzpatrickandBrad Fitzpatrick 7e201806b1 wgengine/magicsock: reconnect to DERP home after network comes back up 
Updates #1310
 2021-02-10 10:29:03 -08:00
Brad Fitzpatrick cbd6224ca4 wgengine/winnet: don't build on non-windows 
It only affects 'go install ./...', etc, and only on darwin/arm64 (M1 Macs) where
the go-ole package doesn't compile.

No need to build it.

Updates #943
 2021-02-09 21:09:24 -08:00
Brad Fitzpatrick 9b4e50cec0 wgengine/magicsock: fix typo in comment 2021-02-09 09:37:24 -08:00
Brad FitzpatrickandBrad Fitzpatrick 6b365b0239 wgengine/magicsock: fix DERP reader hang regression during concurrent reads 
Fixes #1282

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-08 14:30:15 -08:00
Brad Fitzpatrick 6d2b8df06d wgengine/magicsock: add disabled failing (deadlocking) test for #1282 
The fix can make this test run unconditionally.

This moves code from 5c619882bc for
testability but doesn't fix it yet. The #1282 problem remains (when I
wrote its wake-up mechanism, I forgot there were N DERP readers
funneling into 1 UDP reader, and the code just isn't correct at all
for that case).

Also factor out some test helper code from BenchmarkReceiveFrom.

The refactoring in magicsock.go for testability should have no
behavior change.
 2021-02-06 21:34:16 -08:00
Brad FitzpatrickandBrad Fitzpatrick 1e7a35b225 types/netmap: split controlclient.NetworkMap off into its own leaf package 
Updates #1278

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-05 16:18:52 -08:00
Brad Fitzpatrick ddfcc4326c types/persist: split controlclient.Persist into a small leaf package 
This one alone doesn't modify the global dependency map much
(depaware.txt if anything looks slightly worse), but it leave
controlclient as only containing NetworkMap:

bradfitz@tsdev:~/src/tailscale.com/ipn$ grep -F "controlclient." *.go
backend.go:     NetMap        *controlclient.NetworkMap // new netmap received
fake_test.go:   b.notify(Notify{NetMap: &controlclient.NetworkMap{}})
fake_test.go:   b.notify(Notify{NetMap: &controlclient.NetworkMap{}})
handle.go:      netmapCache       *controlclient.NetworkMap
handle.go:func (h *Handle) NetMap() *controlclient.NetworkMap {

Once that goes into a leaf package, then ipn doesn't depend on
controlclient at all, and then the client gets smaller.

Updates #1278
 2021-02-05 15:25:33 -08:00
Brad FitzpatrickandBrad Fitzpatrick 6064b6ff47 wgengine/wgcfg/nmcfg: split control/controlclient/netmap.go into own package 
It couldn't move to ipnlocal due to test dependency cycles.

Updates #1278

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-05 14:21:30 -08:00
Brad Fitzpatrick fb6b0e247c cmd/tailscaled: rename Windows service to just Tailscale 
Updates #1232
 2021-02-05 11:13:34 -08:00
Brad Fitzpatrick 98f9e82c62 logpolicy: on Windows, use tailscale-ipn log name if it already existed 
For the migration to tailscaled.exe on Windows, don't create a new logid
if one existed under the old filename.

Updates #1232
 2021-02-05 10:57:51 -08:00
Brad Fitzpatrick e8d4afedd1 control/controlclient: don't call lite endpoint update path when logged out 
This was the other half of the #1271 problem.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-05 10:00:35 -08:00
Brad Fitzpatrick a7562be5e1 cmd/tailscaled: move more of the Windows server setup code into tailscaled 
Updates #1232
 2021-02-05 09:53:54 -08:00
Brad Fitzpatrick 6f7974b7f2 cmd/tailscaled: add missing depaware.txt update 2021-02-05 08:48:00 -08:00
Brad Fitzpatrick 6099ecf7f4 cmd/tailscaled: run as a service on Windows 
Updates #1232
 2021-02-05 08:46:12 -08:00
Brad Fitzpatrick 7529b74018 control/controlclient: avoid crash sending map request with zero node key 
Fixes #1271

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-04 16:23:50 -08:00
Brad FitzpatrickandDave Anderson d76334d2f0 ipn: split LocalBackend off into new ipn/ipnlocal package 
And move a couple other types down into leafier packages.

Now cmd/tailscale doesn't bring in netlink, magicsock, wgengine, etc.

Fixes #1181

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-04 14:04:23 -08:00
Brad Fitzpatrick 6254efb9ef cmd/tailscale{,d}: move debug subcommand to tailscaled 
Work on reducing the size of the tailscale binary, which is
currently pulling in most of the same code as tailscaled.

Updates #1181
 2021-02-04 12:23:06 -08:00
Brad Fitzpatrick 70eb05fd47 wgengine: access flow pending problem with lock held 
Missed review feedback from just-submitted d37058af72.
 2021-02-04 11:18:32 -08:00
Brad FitzpatrickandBrad Fitzpatrick d37058af72 net/packet: add some more TSMP packet reject reasons and MaybeBroken bit 
Unused for now, but I want to backport this commit to 1.4 so 1.6 can
start sending these and then at least 1.4 logs will stringify nicely.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-04 10:59:07 -08:00
Brad FitzpatrickandBrad Fitzpatrick f7eed25bb9 wgengine/magicsock: filter disco packets and packets when stopped from wireguard 
Fixes #1167
Fixes tailscale/corp#219

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-04 09:38:02 -08:00
Brad Fitzpatrick 9a70789853 cmd/tailscale: fix IPN message reading stall in tailscale status -web 
Fixes #1234
Updates #1254
 2021-02-02 14:51:44 -08:00
Brad Fitzpatrick a2aa6cd2ed wgengine/router: clarify disabled IPv6 message on Linux 2021-02-02 14:51:44 -08:00
Brad Fitzpatrick c7d4bf2333 cmd/tailscale/cli: recommend sudo for 'tailscale up' on failure 
Fixes #1220
 2021-02-01 13:53:57 -08:00
Brad FitzpatrickandBrad Fitzpatrick 2889fabaef cmd/tailscaled/tailscaled.service: revert recent hardening for now 
It broke Debian Stretch. We'll try again later.

Updates #1245

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-02-01 13:37:48 -08:00
Brad Fitzpatrick 761188e5d2 wgengine/wgcfg: fix validateEndpoints of empty string 
Updates tailscale/corp#1238
 2021-01-30 11:17:55 -08:00
Brad Fitzpatrick 914a486af6 safesocket: refactor macOS auth code, pull out separate LocalTCPPortAndToken 2021-01-29 14:34:57 -08:00
Brad Fitzpatrick 60e189f699 cmd/hello: use safesocket client to connect 2021-01-29 13:49:17 -08:00
Brad Fitzpatrick 006a224f50 ipn/ipnserver, cmd/hello: do whois over unix socket, not debug http 
Start of a local HTTP API. Not a stable interface yet.
 2021-01-29 13:23:13 -08:00
Brad FitzpatrickandBrad Fitzpatrick 0bc73f8e4f cmd/hello: new hello.ipn.dev server 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-01-29 12:23:13 -08:00
Brad Fitzpatrick c611d8480b cmd/tailscaled: add whois/identd-ish debug handler 2021-01-28 15:31:52 -08:00
Brad FitzpatrickandDave Anderson c7fc4a06da wgengine/router: don't configure IPv6 on Linux when IPv6 is unavailable 
Fixes #1214

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-01-28 13:35:11 -08:00
Brad FitzpatrickandBrad Fitzpatrick 4d943536f1 wgengine: don't leak TUN device in NewUserspaceEngine error path 
Updates #1187

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-01-27 11:06:56 -08:00
Brad Fitzpatrick 9f5b0d058f wgengine: fix bugs from earlier fix 
Fixes a regression from e970ed0995 that wasn't covered by tests
in this repo. (Our end-to-end tests in another repo caught this.)

Updates #1204
 2021-01-27 10:32:08 -08:00
Brad FitzpatrickandBrad Fitzpatrick 35e10c78fc net/interfaces: don't send over zt* interfaces 
Fixes #1208

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-01-26 15:20:43 -08:00
Brad FitzpatrickandBrad Fitzpatrick e970ed0995 wgengine: fix crash reading long UAPI lines from legacy peers 
Also don't log.Fatalf in a function returning an error.

Fixes #1204

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-01-26 11:39:13 -08:00
Brad Fitzpatrick a7edcd0872 ipn/ipnstate: update tailscale status -web to match CLI 2021-01-26 08:29:59 -08:00
Brad Fitzpatrick a98538f84a Merge branch 'main' of github.com:tailscale/tailscale into main 2021-01-25 15:53:13 -08:00
Brad FitzpatrickandBrad Fitzpatrick c3c59445ff ipn/ipnserver: on Windows in unattended mode, wait for Engine forever 
Updates #1187
 2021-01-25 15:52:24 -08:00
Brad Fitzpatrick 0dde8fa0a8 ipn/ipnserver: rearrange some code 
No functional change. Make a future diff easier to read.
 2021-01-25 15:46:39 -08:00
Brad Fitzpatrick 4d3c09ced4 ipn/ipnserver: on Windows in unattended mode, wait for Engine forever 
Updates #1187
 2021-01-25 15:32:13 -08:00
Brad Fitzpatrick 4fea604979 wgengine/router: stop setPrivateNetwork goroutine on configureInterface failure 
On Windows, configureInterface starts a goroutine reconfiguring the
Windows firewall.

But if configureInterface fails later, that goroutine kept running and
likely failing forever, spamming logs. Make it stop quietly if its
launching goroutine filed.
 2021-01-25 13:22:51 -08:00