Maisem Ali and Maisem Ali
18c7c3981a
ipn/ipnlocal: call checkPrefs in Start too
...
We were not calling checkPrefs on `opts.*Prefs` in (*LocalBackend).Start().
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-22 15:13:00 +05:00
Maisem Ali and Brad Fitzpatrick
41dd49391f
tstest/integration: add --accept-risk=all to tailscale down
...
The test would fail if I was running it over SSH.
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-21 17:33:37 -08:00
Brad Fitzpatrick and Brad Fitzpatrick
0480a925c1
ipn/ipnlocal: send Content-Security-Policy, etc to peerapi browser requests
...
Updates tailscale/corp#7948
Change-Id: Ie70e0d042478338a37b7789ac63225193e47a524
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-21 17:33:06 -08:00
Luke Rewega and GitHub
b190c1667b
words: add some cloven-hoofed ruminants ( #6393 )
...
The Bovini tribe is sorely underrepresented.
Signed-off-by: Luke Rewega <lrewega@c32.ca >
2022-11-21 16:49:00 -08:00
License Updater and Will Norris
5c9203669a
licenses: update tailscale{,d} licenses
...
Signed-off-by: License Updater <noreply@tailscale.com >
2022-11-21 15:21:30 -08:00
Andrew Dunham
a0ef51f570
cmd/{tailscale,tailscaled}: embed manifest into Windows binaries
...
This uses a go:generate statement to create a bunch of .syso files that
contain a Windows resource file. We check these in since they're less
than 1KiB each, and are only included on Windows.
Fixes #6429
Signed-off-by: Andrew Dunham <andrew@du.nham.ca >
Change-Id: I0512c3c0b2ab9d8d8509cf2037b88b81affcb81f
2022-11-21 18:15:51 -05:00
Maisem Ali and Maisem Ali
b94b91c168
cmd/tailscale/cli: add ability to set short names for profiles
...
This adds a `--nickname` flag to `tailscale login|set`.
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-22 04:03:24 +05:00
Maisem Ali and Maisem Ali
575fd5f22b
ipn: add ability to name profiles
...
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-22 04:03:24 +05:00
Mihai Parparita and Mihai Parparita
33520920c3
all: use strs.CutPrefix and strs.CutSuffix more
...
Updates places where we use HasPrefix + TrimPrefix to use the combined
function.
Updates #5309
Signed-off-by: Mihai Parparita <mihai@tailscale.com >
2022-11-21 14:32:16 -08:00
Aaron Klotz
41e1d336cc
net/dns: change windows DNS manager to use pointer receiver
...
This is safer given that we need to close the NRPT database.
Signed-off-by: Aaron Klotz <aaron@tailscale.com >
2022-11-21 15:46:51 -06:00
shayne and GitHub
bdd8ce6692
cmd/tailscale/cli: disallow empty text "" from serve CLI ( #6416 )
...
Current behavior is broken. tailscale serve text / "" returns no error
and shows up in tailscale serve status but requests return a 500
"empty handler".
Adds an error if the user passes in an empty string for the text
handler.
Closes #6405
Signed-off-by: Shayne Sweeney <shayne@tailscale.com >
2022-11-20 15:04:58 -05:00
shayne and GitHub
d1e1c025b0
tailcfg: add TailscaleFunnelEnabled to HostInfo ( #6414 )
...
Adding this convenience for tailscale/corp#8015 and to avoid leaking
WireIngress.
Signed-off-by: Shayne Sweeney <shayne@tailscale.com >
2022-11-20 13:22:54 -05:00
Charlotte Brandhorst-Satzkorn and GitHub
538f431d5d
words: no explanation necessary ( #6413 )
...
Scales do not exist without a banana.
Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com >
2022-11-20 00:01:01 -05:00
Charlotte Brandhorst-Satzkorn and GitHub
aac3d5bdd1
words: good vibes only ( #6412 )
...
After consultation with Tom, it has been agreed that a vibe, or vibes,
can be felt in different quantifiable measures. That makes a vibe, or
vibes, a scale thus it must be immortalized.
Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com >
2022-11-19 23:28:30 -05:00
Brad Fitzpatrick and Brad Fitzpatrick
039ea51ca6
ipn/ipnlocal: add health warning for unstable builds
...
Like the macOS About dialog.
Change-Id: Ic27f091e66e29d5eebe4e195eda97ed331d748fd
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-19 14:22:39 -08:00
Brad Fitzpatrick and Brad Fitzpatrick
a26f23d949
ipn/ipnlocal: actually fill out PeerAPIURLs in PeerStatus
...
The earlier 5f6d63936f was not complete.
Updates tailscale/corp#7515
Change-Id: I35efca51d1584c48ef6834a7d29cd42d7c943628
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-19 13:35:39 -08:00
Charlotte Brandhorst-Satzkorn and GitHub
063eeefdca
words: where do penguins go when they lose their tail? ( #6403 )
...
To the retail store.
Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com >
2022-11-19 12:37:48 -05:00
Charlotte Brandhorst-Satzkorn and GitHub
92fa0313d0
words: this list is really sheeping up to be something ( #6399 )
...
Ewe wouldn't have thought it was started as a joke.
Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com >
2022-11-19 07:17:00 -08:00
shayne and GitHub
f52a6d1b8c
cmd/tailscale/cli, ipn: move serve CLI funcs on to ServeConfig ( #6401 )
...
Signed-off-by: Shayne Sweeney <shayne@tailscale.com >
2022-11-19 09:42:14 -05:00
Charlotte Brandhorst-Satzkorn and GitHub
2847dd2aef
words: you goatta be kid'in me ( #6397 )
...
My puns are so baaaaaaad
Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com >
2022-11-19 00:45:45 -05:00
mel and GitHub
e2f8b84170
words: add "coyote" to the wordlist for tailnet names ( #6396 )
...
Signed-off-by: yotes <yotes@fastmail.com >
2022-11-19 00:22:46 -05:00
License Updater and Denton Gentry
2eb0687969
licenses: update win/apple licenses
...
Signed-off-by: License Updater <noreply@tailscale.com >
2022-11-18 19:10:05 -08:00
Brad Fitzpatrick and Brad Fitzpatrick
3a168cc1ff
wgengine/magicsock: ignore pre-disco (pre-0.100) peers
...
There aren't any in the wild, other than one we ran on purpose to keep
us honest, but we can bump that one forward to 0.100.
Change-Id: I129e70724b2d3f8edf3b496dc01eba3ac5a2a907
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-18 17:52:08 -08:00
Tom DNetto and Tom
2a991a3541
ipn/{localapi,ipnserver}: set a CSP for ServeHTMLStatus, refactor host check
...
Signed-off-by: Tom DNetto <tom@tailscale.com >
2022-11-18 16:13:09 -08:00
a011320370
magicsock: cleanup canp2p ( #6391 )
...
This renames canP2P in magicsock to canP2PLocked to reflect
expectation of mutex lock, fixes a race we discovered in the meantime,
and updates the current stats.
Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com >
Signed-off-by: Jenny Zhang <jz@tailscale.com >
2022-11-18 12:23:22 -08:00
Maisem Ali and Maisem Ali
f1ad26f694
ipn/ipnlocal: strip NetworkLockKey from Prefs
...
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-19 00:57:49 +05:00
Anton Tolchanov and Anton Tolchanov
f40bb199f5
tsweb: cache prometheus metric names & types
...
Signed-off-by: Anton Tolchanov <anton@tailscale.com >
2022-11-18 19:52:37 +00:00
Anton Tolchanov and Anton Tolchanov
3c27632ffe
tsweb: avoid dashes in Prometheus metric names
...
Ideally we should strip other invalid characters too, but that would
call for a regexp replacement which increases the number of allocations
and makes `TestVarzHandlerSorting` fail.
Signed-off-by: Anton Tolchanov <anton@tailscale.com >
2022-11-18 19:52:37 +00:00
Maisem Ali and Maisem Ali
dd50dcd067
ipn/ipnlocal: handle untagging nodes better
...
We would end up with duplicate profiles for the node as the UserID
would have chnaged. In order to correctly deduplicate profiles, we
need to look at both the UserID and the NodeID. A single machine can
only ever have 1 profile per NodeID and 1 profile per UserID.
Note: UserID of a Node can change when the node is tagged/untagged,
and the NodeID of a device can change when the node is deleted so we
need to check for both.
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-18 14:00:19 +05:00
Brad Fitzpatrick and Brad Fitzpatrick
f18dde6ad1
ipn/ipnserver: validate Host header on debug ServeHTMLStatus status
...
Updates tailscale/corp#7948
Change-Id: I3a8c64f353af1eeae620812b2700ce4af4fbbc88
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-17 23:02:40 -08:00
Brad Fitzpatrick and Brad Fitzpatrick
a13753ae1e
ipn/localapi: require POST to add a bugreport marker
...
The LocalClient.BugReport method already sends it via POST.
Updates tailscale/corp#7948
Change-Id: I98dbd558c99d4296d934baa5ebc97052c7413073
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-17 21:54:06 -08:00
b5299d7d0e
portlist: wait for lsof cmd to exit
...
We were leaking processes otherwise.
Co-authored-by: Mihai Parparita <mihai@tailscale.com >
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-18 03:42:35 +05:00
shayne and GitHub
a97369f097
cmd/tailscale/cli: flesh out serve CLI and tests ( #6304 )
...
Signed-off-by: Shayne Sweeney <shayne@tailscale.com >
2022-11-17 16:09:43 -05:00
Maisem Ali and Maisem Ali
5f6d63936f
ipn/ipnlocal: fill out PeerAPIURLs in PeerStatus
...
Updates tailscale/corp#7515
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-18 01:49:32 +05:00
Andrew Dunham
0af61f7c40
cmd/tailscale, util/quarantine: set quarantine flags on files from Taildrop
...
This sets the "com.apple.quarantine" flag on macOS, and the
"Zone.Identifier" alternate data stream on Windows.
Change-Id: If14f805467b0e2963067937d7f34e08ba1d1fa85
Signed-off-by: Andrew Dunham <andrew@du.nham.ca >
2022-11-17 15:06:02 -05:00
Andrew Dunham
cec48743fb
ipn/localapi: set security headers
...
Change-Id: I028b6ab91229e2f824e5a69856ca9e1844f7486e
Signed-off-by: Andrew Dunham <andrew@du.nham.ca >
2022-11-17 10:59:13 -05:00
Will Norris and Will Norris
1b8c13e18a
words: help mercat get her sparkle back
...
Signed-off-by: Will Norris <will@tailscale.com >
2022-11-16 23:27:13 -08:00
Maisem Ali and Maisem Ali
f3519f7b29
cmd/tailscale/cli: add login and switch subcommands
...
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-17 10:27:56 +05:00
Joe Tsai and GitHub
ec1e67b1ab
tstime: fix ParseDuration for '6' digit ( #6363 )
...
The cutset provided to strings.TrimRight was missing the digit '6',
making it such that we couldn't parse something like "365d".
Signed-off-by: Joe Tsai <joetsai@digital-static.net >
2022-11-16 21:01:09 -08:00
Joe Tsai and GitHub
eff62b7b1b
logtail: remove MustParsePublicID ( #6335 )
...
This function is no longer necessary as you can trivially rewrite:
logtail.MustParsePublicID(...)
with:
must.Get(logtail.ParsePublicID(...))
Signed-off-by: Joe Tsai <joetsai@digital-static.net >
2022-11-16 15:38:27 -08:00
1de64e89cd
ipn/ipnlocal: set Hostinfo.WireIngress when ingress enabled
...
Optimization for control.
Updates tailscale/corp#7515
Change-Id: Ie93b232ab3e543d53062b462bdc13e279176f7a9
Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com >
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-17 02:39:25 +05:00
Mihai Parparita and Mihai Parparita
b3da5de10f
ipn/localapi: also allow localhost as the LocalAPI host
...
The Mac and iOS LocalAPI clients make requests to it.
Signed-off-by: Mihai Parparita <mihai@tailscale.com >
2022-11-16 12:11:45 -08:00
Maisem Ali and Maisem Ali
b0736fe6f7
ipn/ipnlocal: move selfNode from peerAPIServer to peerAPIHandler
...
The peerAPIHandler is instantiated per PeerAPI call so it is
guaranteed to have the latest selfNode.
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-17 01:02:03 +05:00
Maisem Ali and Maisem Ali
2f4fca65a1
ipn/ipnlocal: prevent duplicate profiles of the same user
...
Updates #713
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-17 00:59:55 +05:00
Brad Fitzpatrick and Brad Fitzpatrick
e9c851b04b
ipn/ipnlocal: also accept service IP IPv6 literal in brackets for quad100
...
The fix in 4fc8538e2 was sufficient for IPv6. Browsers (can?) send the
IPv6 literal, even without a port number, in brackets.
Updates tailscale/corp#7948
Change-Id: I0e429d3de4df8429152c12f251ab140b0c8f6b77
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-16 11:47:42 -08:00
Maisem Ali and Maisem Ali
296e712591
tailcfg: add CapabilityDebug
...
Updates tailscale/corp#7948
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-17 00:21:10 +05:00
Maisem Ali and Maisem Ali
1e78fc462c
ipn/ipnlocal: add some validation to PeerAPI
...
Updates tailscale/corp#7948
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-16 23:33:53 +05:00
Maisem Ali and Maisem Ali
1f4669a380
all: standardize on LocalAPI
...
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-16 23:15:24 +05:00
Maisem Ali and Maisem Ali
22238d897b
all: standardize on PeerAPI
...
Signed-off-by: Maisem Ali <maisem@tailscale.com >
2022-11-16 22:49:13 +05:00
Brad Fitzpatrick and Brad Fitzpatrick
1b56acf513
ipn/ipnlocal: move LocalBackend.validPopBrowserURL empty check from caller
...
I was too late with review feedback to 513780f4f8 .
Updates tailscale/corp#7948
Change-Id: I8fa3b4eba4efaff591a2d0bfe6ab4795638b7c3a
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com >
2022-11-16 09:43:43 -08:00