ipn/ipnlocal: log errors when suggesting exit nodes (#18728)

In PR #18681, we started logging which exit nodes were being
suggested. However, we did not log if there were errors encountered.
This patch corrects this oversight.

Updates: tailscale/corp#29964
Updates: tailscale/corp#36446

Signed-off-by: Simon Law <sfllaw@tailscale.com>
main
Simon Law 2 months ago committed by GitHub
parent 371d6369cd
commit 6854d2982b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 8
      ipn/ipnlocal/local.go

@ -7492,8 +7492,12 @@ func suggestExitNode(report *netcheck.Report, nb *nodeBackend, prevSuggestion ta
// it is set in the policy file: tailscale/corp#34401
res, err = suggestExitNodeUsingDERP(report, nb, prevSuggestion, selectRegion, selectNode, allowList)
}
name, _, _ := strings.Cut(res.Name, ".")
nb.logf("netmap: suggested exit node: %s (%s)", name, res.ID)
if err != nil {
nb.logf("netmap: suggested exit node: %v", err)
} else {
name, _, _ := strings.Cut(res.Name, ".")
nb.logf("netmap: suggested exit node: %s (%s)", name, res.ID)
}
return res, err
}

Loading…
Cancel
Save