util/set: make Clone a method (#10044)

Updates #cleanup

Signed-off-by: Chris Palmer <cpalmer@tailscale.com>

util/set/set.go

@@ -19,7 +19,7 @@ func SetOf[T comparable](slice []T) Set[T] {
 }
 
 // Clone returns a new set cloned from the elements in s.
-func Clone[T comparable](s Set[T]) Set[T] {
+func (s Set[T]) Clone() Set[T] {
 	return maps.Clone(s)
 }
 

util/set/set_test.go

@@ -103,7 +103,7 @@ func TestClone(t *testing.T) {
 	if s.Len() != 4 {
 		t.Errorf("wrong len %d; want 4", s.Len())
 	}
-	s2 := Clone(s)
+	s2 := s.Clone()
 	if !s.Equal(s2) {
 		t.Error("clone not equal to original")
 	}