control/controlclient: don't use Node as value type

control/controlclient/direct.go

@@ -18,7 +18,6 @@ import (
 	"net/http"
 	"os"
 	"runtime"
-	"strconv"
 	"strings"
 	"sync"
 	"time"
@@ -564,14 +563,6 @@ func (c *Direct) PollNetMap(ctx context.Context, maxPolls int, cb func(*NetworkM
 			Hostinfo:     resp.Node.Hostinfo,
 			PacketFilter: resp.PacketFilter,
 		}
-		// Temporary (2020-02-21) knob to force debug, during DERP testing:
-		if ok, _ := strconv.ParseBool(os.Getenv("DEBUG_FORCE_DERP")); ok {
-			c.logf("debug: adding DERP endpoints to all peers")
-			for i := range nm.Peers {
-				peer := &nm.Peers[i]
-				peer.Endpoints = append([]string{"127.3.3.40:1"}, peer.Endpoints...)
-			}
-		}
 		for _, profile := range resp.UserProfiles {
 			nm.UserProfiles[profile.ID] = profile
 		}

control/controlclient/netmap.go

@@ -28,7 +28,7 @@ type NetworkMap struct {
 	Addresses     []wgcfg.CIDR
 	LocalPort     uint16 // used for debugging
 	MachineStatus tailcfg.MachineStatus
-	Peers         []tailcfg.Node
+	Peers         []*tailcfg.Node
 	DNS           []wgcfg.IP
 	DNSDomains    []string
 	Hostinfo      tailcfg.Hostinfo

tailcfg/tailcfg.go

@@ -404,8 +404,8 @@ type MapResponse struct {
 	KeepAlive bool // if set, all other fields are ignored
 
 	// Networking
-	Node        Node
-	Peers       []Node
+	Node        *Node
+	Peers       []*Node
 	DNS         []wgcfg.IP
 	SearchPaths []string