Jonathan Nobels
643e91f2eb
fixes tailscale/tailscale#18418 Both Serve and PeerAPI broke when we moved the TailscaleInterfaceName into State, which is updated asynchronously and may not be available when we configure the listeners. This extracts the explicit interface name property from netmon.State and adds as a static struct with getters that have proper error handling. The bug is only found in sandboxed Darwin clients, where we need to know the Tailscale interface details in order to set up the listeners correctly (they must bind to our interface explicitly to escape the network sandboxing that is applied by NECP). Currently set only sandboxed macOS and Plan9 set this but it will also be useful on Windows to simplify interface filtering in netns. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
94 lines
2.4 KiB
Go
94 lines
2.4 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package netmon
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"testing/synctest"
|
|
|
|
"tailscale.com/util/eventbus"
|
|
"tailscale.com/util/eventbus/eventbustest"
|
|
)
|
|
|
|
func TestLinkChangeLogLimiter(t *testing.T) { synctest.Test(t, syncTestLinkChangeLogLimiter) }
|
|
|
|
func syncTestLinkChangeLogLimiter(t *testing.T) {
|
|
bus := eventbus.New()
|
|
defer bus.Close()
|
|
mon, err := New(bus, t.Logf)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer mon.Close()
|
|
|
|
var logBuffer bytes.Buffer
|
|
logf := func(format string, args ...any) {
|
|
t.Logf("captured log: "+format, args...)
|
|
|
|
if format[len(format)-1] != '\n' {
|
|
format += "\n"
|
|
}
|
|
fmt.Fprintf(&logBuffer, format, args...)
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
defer cancel()
|
|
|
|
logf = LinkChangeLogLimiter(ctx, logf, mon)
|
|
|
|
// Log once, which should write to our log buffer.
|
|
logf("hello %s", "world")
|
|
if got := logBuffer.String(); got != "hello world\n" {
|
|
t.Errorf("unexpected log buffer contents: %q", got)
|
|
}
|
|
|
|
// Log again, which should not write to our log buffer.
|
|
logf("hello %s", "andrew")
|
|
if got := logBuffer.String(); got != "hello world\n" {
|
|
t.Errorf("unexpected log buffer contents: %q", got)
|
|
}
|
|
|
|
// Log a different message, which should write to our log buffer.
|
|
logf("other message")
|
|
if got := logBuffer.String(); got != "hello world\nother message\n" {
|
|
t.Errorf("unexpected log buffer contents: %q", got)
|
|
}
|
|
|
|
// Synthesize a fake major change event, which should clear the format
|
|
// string cache and allow the next log to write to our log buffer.
|
|
//
|
|
// InjectEvent doesn't work because it's not a major event, so we
|
|
// instead inject the event ourselves.
|
|
injector := eventbustest.NewInjector(t, bus)
|
|
cd, err := NewChangeDelta(nil, &State{}, true, true)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if cd.RebindLikelyRequired != true {
|
|
t.Fatalf("expected RebindLikelyRequired to be true, got false")
|
|
}
|
|
eventbustest.Inject(injector, cd)
|
|
synctest.Wait()
|
|
|
|
logf("hello %s", "world")
|
|
want := "hello world\nother message\nhello world\n"
|
|
if got := logBuffer.String(); got != want {
|
|
t.Errorf("unexpected log buffer contents, got: %q, want, %q", got, want)
|
|
}
|
|
|
|
// Canceling the context we passed to LinkChangeLogLimiter should
|
|
// unregister the callback from the netmon.
|
|
cancel()
|
|
synctest.Wait()
|
|
|
|
mon.mu.Lock()
|
|
if len(mon.cbs) != 0 {
|
|
t.Errorf("expected no callbacks, got %v", mon.cbs)
|
|
}
|
|
mon.mu.Unlock()
|
|
}
|