You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nick Khyl da9965d51c cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible ... In this PR, we add a generic views.ValuePointer type that can be used as a view for pointers to basic types and struct types that do not require deep cloning and do not have corresponding view types. Its Get/GetOk methods return stack-allocated shallow copies of the underlying value. We then update the cmd/viewer codegen to produce getters that return either concrete views when available or ValuePointer views when not, for pointer fields in generated view types. This allows us to avoid unnecessary allocations compared to returning pointers to newly allocated shallow copies. Updates #14570 Signed-off-by: Nick Khyl <nickk@tailscale.com>		1 year ago
..
tests	cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible	1 year ago
viewer.go	cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible	1 year ago
viewer_test.go	cmd/viewer: import types/views when generating a getter for a map field	2 years ago