You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nick Hill c2144c44a3 net/dns/resolver: update (*forwarder).forwardWithDestChan to always return an error unless it sends a response to responseChan ... We currently have two executions paths where (*forwarder).forwardWithDestChan returns nil, rather than an error, without sending a DNS response to responseChan. These paths are accompanied by a comment that reads: // Returning an error will cause an internal retry, there is // nothing we can do if parsing failed. Just drop the packet. But it is not (or no longer longer) accurate: returning an error from forwardWithDestChan does not currently cause a retry. Moreover, although these paths are currently unreachable due to implementation details, if (*forwarder).forwardWithDestChan were to return nil without sending a response to responseChan, it would cause a deadlock at one call site and a panic at another. Therefore, we update (*forwarder).forwardWithDestChan to return errors in those two paths and remove comments that were no longer accurate and misleading. Updates #cleanup Updates #13571 Signed-off-by: Nick Hill <mykola.khyl@gmail.com>		2 years ago
..
art	all: fix new lint warnings from bumping staticcheck	2 years ago
captivedetection	net/captivedetection: set Timeout on net.Dialer (#13613)	2 years ago
connstats	all: use Go 1.22 range-over-int	2 years ago
dns	net/dns/resolver: update (*forwarder).forwardWithDestChan to always return an error unless it sends a response to responseChan	2 years ago
dnscache	net/dnscache: don't fall back to an IPv6 dial if we don't have IPv6	2 years ago
dnsfallback	{control,net}: close idle connections of custom transports	2 years ago
flowtrack	net/flowtrack: fix, test String method	2 years ago
ipset	go.mod: bump bart	2 years ago
ktimeout	net/ktimeout: add a package to set TCP user timeout	2 years ago
memnet	net/memnet: export the network name (#9111)	3 years ago
netaddr	all: update copyright and license headers	3 years ago
netcheck	net/netcheck: fix netcheck cli-triggered nil pointer deref (#13782)	2 years ago
neterror	net/neterror, wgengine/magicsock: use UDP GSO and GRO on Linux (#7791)	3 years ago
netkernelconf	ipn/{ipnlocal,localapi},net/netkernelconf,client/tailscale,cmd/containerboot: optionally enable UDP GRO forwarding for containers (#12410)	2 years ago
netknob	all: update copyright and license headers	3 years ago
netmon	all: fix new lint warnings from bumping staticcheck	2 years ago
netns	net/netns: remove some logspam by avoiding logging parse errors due to unspecified addresses	2 years ago
netstat	all: add test for package comments, fix, add comments as needed	2 years ago
netutil	{ipn,net,tsnet}: use tsaddr helpers	2 years ago
packet	wgengine/magicsock: actually use AF_PACKET socket for raw disco	2 years ago
ping	net/ping: fix ICMP echo code field to 0	3 years ago
portmapper	net/portmapper: don't treat 0.0.0.0 as a valid IP	2 years ago
proxymux	all: cleanup unused code, part 1 (#10661)	2 years ago
routetable	net/{interfaces,netmon}, all: merge net/interfaces package into net/netmon	2 years ago
socks5	net/socks5: support UDP	2 years ago
sockstats	net/sockstats: quiet some log spam in release builds	2 years ago
speedtest	all: update copyright and license headers	3 years ago
stun	ci: enable checklocks workflow for specific packages	2 years ago
stunserver	all: use Go 1.22 range-over-int	2 years ago
tcpinfo	all: use Go 1.22 range-over-int	2 years ago
tlsdial	cmd/tta, vnet: add host firewall, env var support, more tests	2 years ago
tsaddr	net/tsaddr: add WithoutExitRoutes and IsExitRoute	2 years ago
tsdial	{control,net}: close idle connections of custom transports	2 years ago
tshttpproxy	all: use Go 1.22 range-over-int	2 years ago
tstun	util/usermetrics: make usermetrics non-global	2 years ago
wsconn	go.{mod,sum}: migrate from nhooyr.io/websocket to github.com/coder/websocket	2 years ago