f5eac39ea ("feature/acme, ipn/ipnlocal: start moving ACME/cert state
into an extension") started to move the cert code into feature/acme
but was meant as a baby step.
This goes further, moving almost everything, leaving only some hooks
in ipnlocal.
When we later move "serve" support out to feature/serve, this will
look a bit different in that the hooks currently in ipnlocal will move
to feature/serve (cert support already depends on serve).
As part of this, cert-related tests move to feaure/acme too, which
means some test infra from ipnlocal now moves to shared ipnlocaltest.
(it's not big at the moment, but I imagine it growing)
Updates #12614
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Change-Id: I9ea89aa9754f12d54b81751b6bd830f2664241ff
136 lines
3.4 KiB
Go
136 lines
3.4 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
//go:build !ios && !android && !js
|
|
|
|
package acme
|
|
|
|
import (
|
|
"cmp"
|
|
"crypto/x509"
|
|
"encoding/json"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"tailscale.com/ipn/ipnlocal/ipnlocaltest"
|
|
"tailscale.com/tailcfg"
|
|
"tailscale.com/tstest"
|
|
"tailscale.com/types/logger"
|
|
"tailscale.com/util/must"
|
|
)
|
|
|
|
func TestHandleC2NTLSCertStatus(t *testing.T) {
|
|
b := ipnlocaltest.NewBackend(t)
|
|
b.SetVarRoot(t.TempDir())
|
|
e := extOf(t, b)
|
|
|
|
certDirPath, err := certDir(b)
|
|
if err != nil {
|
|
t.Fatalf("certDir error: %v", err)
|
|
}
|
|
if _, err := e.getCertStore(b); err != nil {
|
|
t.Fatalf("getCertStore error: %v", err)
|
|
}
|
|
|
|
testRoot, err := certTestFS.ReadFile("testdata/rootCA.pem")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
roots := x509.NewCertPool()
|
|
if !roots.AppendCertsFromPEM(testRoot) {
|
|
t.Fatal("Unable to add test CA to the cert pool")
|
|
}
|
|
testX509Roots = roots
|
|
defer func() { testX509Roots = nil }()
|
|
|
|
tests := []struct {
|
|
name string
|
|
domain string
|
|
copyFile bool // copy testdata/example.com.pem to the certDir
|
|
wantStatus int // 0 means 200
|
|
wantError string // wanted non-JSON non-200 error
|
|
now time.Time
|
|
want *tailcfg.C2NTLSCertInfo
|
|
}{
|
|
{
|
|
name: "no-domain",
|
|
wantStatus: 400,
|
|
wantError: "no 'domain'\n",
|
|
},
|
|
{
|
|
name: "missing",
|
|
domain: "example.com",
|
|
want: &tailcfg.C2NTLSCertInfo{
|
|
Error: "no certificate",
|
|
Missing: true,
|
|
},
|
|
},
|
|
{
|
|
name: "valid",
|
|
domain: "example.com",
|
|
now: time.Date(2023, time.February, 20, 0, 0, 0, 0, time.UTC),
|
|
copyFile: true,
|
|
want: &tailcfg.C2NTLSCertInfo{
|
|
Valid: true,
|
|
NotBefore: "2023-02-07T20:34:18Z",
|
|
NotAfter: "2025-05-07T19:34:18Z",
|
|
},
|
|
},
|
|
{
|
|
name: "expired",
|
|
domain: "example.com",
|
|
now: time.Date(2030, time.February, 20, 0, 0, 0, 0, time.UTC),
|
|
copyFile: true,
|
|
want: &tailcfg.C2NTLSCertInfo{
|
|
Error: "cert expired",
|
|
Expired: true,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
os.RemoveAll(certDirPath) // reset per test
|
|
if tt.copyFile {
|
|
os.MkdirAll(certDirPath, 0755)
|
|
if err := os.WriteFile(filepath.Join(certDirPath, "example.com.crt"),
|
|
must.Get(certTestFS.ReadFile("testdata/example.com.pem")), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(certDirPath, "example.com.key"),
|
|
must.Get(certTestFS.ReadFile("testdata/example.com-key.pem")), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
b.ForTest().SetClock(tstest.NewClock(tstest.ClockOpts{
|
|
Start: tt.now,
|
|
}))
|
|
|
|
rec := httptest.NewRecorder()
|
|
e.handleC2NTLSCertStatus(b, rec, httptest.NewRequest("GET", "/tls-cert-status?domain="+url.QueryEscape(tt.domain), nil))
|
|
res := rec.Result()
|
|
wantStatus := cmp.Or(tt.wantStatus, 200)
|
|
if res.StatusCode != wantStatus {
|
|
t.Fatalf("status code = %v; want %v. Body: %s", res.Status, wantStatus, rec.Body.Bytes())
|
|
}
|
|
if wantStatus == 200 {
|
|
var got tailcfg.C2NTLSCertInfo
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("bad JSON: %v", err)
|
|
}
|
|
if !reflect.DeepEqual(&got, tt.want) {
|
|
t.Errorf("got %v; want %v", logger.AsJSON(got), logger.AsJSON(tt.want))
|
|
}
|
|
} else if tt.wantError != "" {
|
|
if got := rec.Body.String(); got != tt.wantError {
|
|
t.Errorf("body = %q; want %q", got, tt.wantError)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|