Harry HarphamandAlex Chan 61ac021c5d wgengine/magicsock: assume network up for tests ...

Without this, any test relying on underlying use of magicsock will fail
without network connectivity, even when the test logic has no need for a
network connection. Tests currently in this bucket include many in
tstest/integration and in tsnet.

Further explanation:

ipn only becomes Running when it sees at least one live peer or DERP
connection:
https://github.com/tailscale/tailscale/blob/0cc1b2ff76560ee4675909272fa37ba6b397744c/ipn/ipnlocal/local.go#L5861-L5866

When tests only use a single node, they will never see a peer, so the
node has to wait to see a DERP server.

magicsock sets the preferred DERP server in updateNetInfo(), but this
function returns early if the network is down.
https://github.com/tailscale/tailscale/blob/0cc1b2ff76560ee4675909272fa37ba6b397744c/wgengine/magicsock/magicsock.go#L1053-L1106

Because we're checking the real network, this prevents ipn from entering
"Running" and causes the test to fail or hang.

In tests, we can assume the network is up unless we're explicitly testing
the behaviour of tailscaled when the network is down. We do something similar
in magicsock/derp.go, where we assume we're connected to control unless
explicitly testing otherwise:
https://github.com/tailscale/tailscale/blob/7d2101f3520f16b86f2ed5e15f23c44d720534e6/wgengine/magicsock/derp.go#L166-L177

This is the template for the changes to `networkDown()`.

Fixes #17122

Co-authored-by: Alex Chan <alexc@tailscale.com>
Signed-off-by: Harry Harpham <harry@tailscale.com>

2026-03-31 09:57:14 -06:00

..

blockforever_conn.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

debughttp.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

debugknobs_stubs.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

debugknobs.go

wgengine/magicsock: make debugNeverDirectUDP influence remote peer decisions

2026-01-30 13:16:46 -08:00

derp_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

derp.go

wgengine{,/magicsock}: add DERP hooks for filtering+sending packets

2026-03-11 16:37:19 -07:00

disco_atomic_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

disco_atomic.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

discopingpurpose_string.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint_default.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint_stub.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint_tracker_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint_tracker.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

endpoint.go

wgengine/magicsock,control/controlclient: do not overwrite discokey with old key (#18606)

2026-03-20 08:56:27 -04:00

magicsock_default.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

magicsock_linux_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

magicsock_linux.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

magicsock_notplan9.go

ipn/localapi: stop logging "broken pipe" errors (#18487)

2026-01-26 16:41:03 -08:00

magicsock_plan9.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

magicsock_test.go

wgengine/magicsock: assume network up for tests

2026-03-31 09:57:14 -06:00

magicsock.go

wgengine/magicsock: assume network up for tests

2026-03-31 09:57:14 -06:00

peermap_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermap.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermtu_darwin.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermtu_linux.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermtu_stubs.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermtu_unix.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

peermtu.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

rebinding_conn.go

net/{batching,udprelay},wgengine/magicsock: add SO_RXQ_OVFL clientmetrics

2026-03-13 14:27:03 -07:00

relaymanager_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

relaymanager.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00