08e110ebc5
cmd/tailscale: make "up", "status" warn if routes and --accept-routes off
...
Example output:
# Health check:
# - Some peers are advertising routes but --accept-routes is false
Also, move "tailscale status" health checks to the bottom, where they
won't be lost in large netmaps.
Updates #2053
Updates #6266
Change-Id: I5ae76a0cd69a452ce70063875cd7d974bfeb8f1a
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
3 years ago
4c31183781
cmd/tailscale,ipn: minor fixes to tailscale lock commands
...
* Fix broken add/remove key commands
* Make lock status display whether the node is signed
Signed-off-by: Tom DNetto <tom@tailscale.com>
3 years ago
f00a49667d
control/controlclient: make Status.Persist a PersistView
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
3 years ago
4d330bac14
ipn/ipnlocal: add support for multiple user profiles
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
3 years ago
4de643b714
types/netlogtype: add constants for maximum serialized sizes of ConnectionCounts ( #6163 )
...
There is a finite limit to the maximum message size that logtail can upload.
We need to make sure network logging messages remain under this size.
These constants allow us to compute the maximum number of ConnectionCounts
we can buffer before we must flush.
Signed-off-by: Joe Tsai <joetsai@digital-static.net>
3 years ago
da8def8e13
all: remove old +build tags
...
The //go:build syntax was introduced in Go 1.17:
https://go.dev/doc/go1.17#build-lines
gofmt has kept the +build and go:build lines in sync since
then, but enough time has passed. Time to remove them.
Done with:
perl -i -npe 's,^// \+build.*\n,,' $(git grep -l -F '+build')
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
910db02652
client/tailscale, tsnet, ipn/ipnlocal: prove nodekey ownership over noise
...
Fixes #5972
Change-Id: Ic33a93d3613ac5dbf172d6a8a459ca06a7f9e547
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
f4ff26f577
types/pad32: delete package
...
Use Go 1.19's new 64-bit alignment ~hidden feature instead.
Fixes #5356
Change-Id: Ifcbcb115875a7da01df3bc29e9e7feadce5bc956
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
a3602c28bd
wgengine/netlog: embed the StableNodeID of the authoring node ( #6105 )
...
This allows network messages to be annotated with which node it came from.
Signed-off-by: Joe Tsai <joetsai@digital-static.net>
4 years ago
c21a3c4733
types/netlogtype: new package for network logging types ( #6092 )
...
The netlog.Message type is useful to depend on from other packages,
but doing so would transitively cause gvisor and other large packages
to be linked in.
Avoid this problem by moving all network logging types to a single package.
We also update staticcheck to take in:
003d277bcf
4 years ago
4021ae6b9d
types/key: add missing ChallengePublic.UnmarshalText
...
Forgot it when adding the Challenge types earlier.
Change-Id: Ie0872c4e6dc25e5d832aa58c7b3f66d450bf6b71
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
8c09ae9032
tka, types/key: add NLPublic.KeyID
...
This allows direct use of NLPublic with tka.Authority.KeyTrusted() and
similar without using tricks like converting the return value of Verifier.
Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>
4 years ago
a2d15924fb
types/persist: add PublicNodeKey helper
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
20324eeebc
ipn/prefs: add views
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
18c61afeb9
types/key: add ChallengePublic, ChallengePrivate, NewChallenge
...
Updates #5972
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
5363a90272
types/view: add ContainsNonExitSubnetRoutes func
...
Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
4 years ago
82f5f438e0
wgengine/wgcfg: plumb down audit log IDs ( #5855 )
...
The node and domain audit log IDs are provided in the map response,
but are ultimately going to be used in wgengine since
that's the layer that manages the tstun.Wrapper.
Do the plumbing work to get this field passed down the stack.
Signed-off-by: Joe Tsai <joetsai@digital-static.net>
4 years ago
d4811f11a0
all: fix spelling mistakes
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
4 years ago
b1867457a6
doctor: add package for running in-depth healthchecks; use in bugreport ( #5413 )
...
Change-Id: Iaa4e5b021a545447f319cfe8b3da2bd3e5e5782b
Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
4 years ago
e9b98dd2e1
control/controlclient,ipn/ipnlocal: wire tka enable/disable
...
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
f0347e841f
refactor: move from io/ioutil to io and os packages
...
The io/ioutil package has been deprecated as of Go 1.16 [1]. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.
Reference: https://golang.org/doc/go1.16#ioutil
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
4 years ago
74674b110d
envknob: support changing envknobs post-init
...
Updates #5114
Change-Id: Ia423fc7486e1b3f3180a26308278be0086fae49b
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
2aade349fc
net/dns, types/dnstypes: update some comments, tests for DoH
...
Clarify & verify that some DoH URLs can be sent over tailcfg
in some limited cases.
Updates #2452
Change-Id: Ibb25db77788629c315dc26285a1059a763989e24
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
66d7d2549f
logger: migrate rusage syscall use to x/sys/unix
...
This will be helpful for illumos (#697 ) and should be safe
everywhere else.
Signed-off-by: Nahum Shalman <nahamu@gmail.com>
4 years ago
a78f8fa701
tka: support rotating node-keys in node-key signatures
...
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
facafd8819
client,cmd/tailscale,ipn,tka,types: implement tka initialization flow
...
This PR implements the client-side of initializing network-lock with the
Coordination server.
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
8e821d7aa8
types/opt: support an explicit "unset" value for Bool
...
Updates #4843
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
f50043f6cb
tka,types/key: remove dependency for tailcfg & types/ packages on tka
...
Following the pattern elsewhere, we create a new tka-specific types package for the types
that need to couple between the serialized structure types, and tka.
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
a9f6cd41fd
all: use syncs.AtomicValue
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
8cfd775885
tka,types/key: implement direct node-key signatures
...
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
4001d0bf25
assorted: plumb tka initialization & network-lock key into tailscaled
...
- A network-lock key is generated if it doesn't already exist, and stored in the StateStore. The public component is communicated to control during registration.
- If TKA state exists on the filesystem, a tailnet key authority is initialized (but nothing is done with it for now).
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
8d45d7e312
types/key: make NLPublic complement to NLPrivate
...
Forgot that I would need that in control. Oops.
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
116f55ff66
all: gofmt for Go 1.19
...
Updates #5210
Change-Id: Ib02cd5e43d0a8db60c1f09755a8ac7b140b670be
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
a029989aff
types/dnstype: use viewer instead of cloner
...
This was missed when I did the initial viewer work.
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
023d4e2216
tka,types/key: implement NLPrivate glue for tailnet key authority keys
...
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
51c3d74095
types/views: add BenchmarkSliceIteration
...
```
goos: darwin
goarch: arm64
pkg: tailscale.com/types/views
BenchmarkSliceIteration/Len-10 340093 3212 ns/op 0 B/op 0 allocs/op
BenchmarkSliceIteration/Cached-Len-10 366727 3211 ns/op 0 B/op 0 allocs/op
BenchmarkSliceIteration/direct-10 361561 3290 ns/op 0 B/op 0 allocs/op
PASS
ok tailscale.com/types/views 3.662s
```
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
a12aad6b47
all: convert more code to use net/netip directly
...
perl -i -npe 's,netaddr.IPPrefixFrom,netip.PrefixFrom,' $(git grep -l -F netaddr.)
perl -i -npe 's,netaddr.IPPortFrom,netip.AddrPortFrom,' $(git grep -l -F netaddr. )
perl -i -npe 's,netaddr.IPPrefix,netip.Prefix,g' $(git grep -l -F netaddr. )
perl -i -npe 's,netaddr.IPPort,netip.AddrPort,g' $(git grep -l -F netaddr. )
perl -i -npe 's,netaddr.IP\b,netip.Addr,g' $(git grep -l -F netaddr. )
perl -i -npe 's,netaddr.IPv6Raw\b,netip.AddrFrom16,g' $(git grep -l -F netaddr. )
goimports -w .
Then delete some stuff from the net/netaddr shim package which is no
longer neeed.
Updates #5162
Change-Id: Ia7a86893fe21c7e3ee1ec823e8aba288d4566cd8
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
6a396731eb
all: use various net/netip parse funcs directly
...
Mechanical change with perl+goimports.
Changed {Must,}Parse{IP,IPPrefix,IPPort} to their netip variants, then
goimports -d .
Finally, removed the net/netaddr wrappers, to prevent future use.
Updates #5162
Change-Id: I59c0e38b5fbca5a935d701645789cddf3d7863ad
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
7eaf5e509f
net/netaddr: start migrating to net/netip via new netaddr adapter package
...
Updates #5162
Change-Id: Id7bdec303b25471f69d542f8ce43805328d56c12
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
2024008667
types/key: add MachinePrecomputedSharedKey.Open
...
Follow-up to cfdb862673tailscale/corp#1709
Change-Id: I7af931a2cb55f9006e1029381663ac21d1794242
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
43f3a969ca
types/views: add SliceContains, View.ContainsFunc, View.IndexFunc
...
We were starting to write these elsewhere as little unexported copies
in misc places.
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
9bd3b5b89c
types/key: add ControlPrivate.Shared wrapper too
...
Follow-up to cfdb862673
4 years ago
cfdb862673
types/key: add naclbox shared key wrapper type + Seal method
...
So the control plane can stop doing precomputations on each naclbox
message.
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
a1e429f7c3
control/controlclient, types/netmap: remove unused LocalPort field
...
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
3a182d5dd6
ipn/ipnstate: add ExitNodeStatus to share the exit node if it is in use, the IP, ID and whether its online. ( #4761 )
...
-
Updates #4619
Signed-off-by: nyghtowl <warrick@tailscale.com>
4 years ago
4d85cf586b
cmd/tailscale, ipn/ipnlocal: add "peerapi" ping type
...
For debugging when stuff like #4750 isn't working.
RELNOTE=tailscale ping -peerapi
Change-Id: I9c52c90fb046e3ab7d2b121387073319fbf27b99
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
4 years ago
ec4c49a338
types/key: make NodePublic implement Shardable ( #4698 )
...
Needed for an experiment in Control.
Signed-off-by: Tom DNetto <tom@tailscale.com>
4 years ago
6dae9e47f9
types/views: remove alloc in hot path
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
395cb588b6
types/views: make SliceOf/MapOf panic if they see a pointer
...
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
d04afc697c
cmd/viewer,types/views: add support for views of maps
...
Updates #4635
Signed-off-by: Maisem Ali <maisem@tailscale.com>
4 years ago
Brad Fitzpatrick
Tom DNetto
Maisem Ali
Joe Tsai
Adrian Dewhurst
Sonia Appasamy
Josh Soref
Andrew Dunham
Eng Zer Jun
Nahum Shalman
Melanie Warrick
Tom