tailscale

Commit Graph

Author	SHA1	Message	Date
Josh Bleecher Snyder	7c1a9e8616	net/nettest: de-flake tests on Windows Windows has a low resolution timer. Some of the tests assumed that unblock takes effect immediately. Consider: t := time.Now() elapsed := time.Now().After(t) It seems plausible that elapsed should always be true. However, with a low resolution timer, that might fail. Change time.Now().After to !time.Now().Before, so that unblocking always takes effect immediately. Fixes #873.	5 years ago
David Crawshaw	41ac4a79d6	net/nettest: new package with net-like testing primitives This is a lot like wiring up a local UDP socket, read and write deadlines work. The big difference is the Block feature, which lets you stop the packet flow without breaking the connection. This lets you emulate broken sockets and test timeouts actually work. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	6 years ago

Author

SHA1

Message

Date

Josh Bleecher Snyder

7c1a9e8616

net/nettest: de-flake tests on Windows

Windows has a low resolution timer.
Some of the tests assumed that unblock takes effect immediately.

Consider:

t := time.Now()
elapsed := time.Now().After(t)

It seems plausible that elapsed should always be true.
However, with a low resolution timer, that might fail.

Change time.Now().After to !time.Now().Before,
so that unblocking always takes effect immediately.

Fixes #873.

5 years ago

David Crawshaw

41ac4a79d6

net/nettest: new package with net-like testing primitives

This is a lot like wiring up a local UDP socket, read and write
deadlines work. The big difference is the Block feature, which
lets you stop the packet flow without breaking the connection.
This lets you emulate broken sockets and test timeouts actually
work.

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>

6 years ago

2 Commits (524fb2c1908dc06b166f2a4fd2015d00b7d5ea92)