tailscale

Commit Graph

Author	SHA1	Message	Date
Andrew Dunham	280255acae	various: add golangci-lint, fix issues (#7905 ) This adds an initial and intentionally minimal configuration for golang-ci, fixes the issues reported, and adds a GitHub Action to check new pull requests against this linter configuration. Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I8f38fbc315836a19a094d0d3e986758b9313f163	3 years ago
James Tucker	b0ed863d55	atomicfile: use /tmp for socket path on macOS macOS does not allow unix socket creation in private temp directories, but global /tmp is ok, so swap out for global temp for now. Updates #7658 Updates #7785 Signed-off-by: James Tucker <jftucker@gmail.com>	3 years ago
James Tucker	f4da995940	atomicfile: reject overwriting irregular files The intent of atomicfile is to overwrite regular files. Most use cases that would overwrite irregular files, unix sockets, named pipes, devices, and so on are more than likely misuse, so disallow them. Fixes #7658 Signed-off-by: James Tucker <james@tailscale.com>	3 years ago

Author

SHA1

Message

Date

Andrew Dunham

280255acae

various: add golangci-lint, fix issues (#7905 )

This adds an initial and intentionally minimal configuration for
golang-ci, fixes the issues reported, and adds a GitHub Action to check
new pull requests against this linter configuration.

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Change-Id: I8f38fbc315836a19a094d0d3e986758b9313f163

3 years ago

James Tucker

b0ed863d55

atomicfile: use /tmp for socket path on macOS

macOS does not allow unix socket creation in private temp directories,
but global /tmp is ok, so swap out for global temp for now.

Updates #7658
Updates #7785

Signed-off-by: James Tucker <jftucker@gmail.com>

3 years ago

James Tucker

f4da995940

atomicfile: reject overwriting irregular files

The intent of atomicfile is to overwrite regular files. Most use cases
that would overwrite irregular files, unix sockets, named pipes,
devices, and so on are more than likely misuse, so disallow them.

Fixes #7658

Signed-off-by: James Tucker <james@tailscale.com>

3 years ago

3 Commits (191e2ce7191f74460116151b77513d1ea2b16950)