all: don't repeat the the word "the" unnecessarily
Updates #cleanup Change-Id: Ic1f430cd5dbf6cc1a385c59074a5d5cabe6fca57 Signed-off-by: Alex Chan <alexc@tailscale.com>
This commit is contained in:
@@ -29,7 +29,7 @@ import (
|
|||||||
const (
|
const (
|
||||||
// tsNetDomain is the domain that this DNS nameserver has registered a handler for.
|
// tsNetDomain is the domain that this DNS nameserver has registered a handler for.
|
||||||
tsNetDomain = "ts.net"
|
tsNetDomain = "ts.net"
|
||||||
// addr is the the address that the UDP and TCP listeners will listen on.
|
// addr is the address that the UDP and TCP listeners will listen on.
|
||||||
addr = ":1053"
|
addr = ":1053"
|
||||||
// defaultTTL is the default TTL for DNS records in seconds.
|
// defaultTTL is the default TTL for DNS records in seconds.
|
||||||
// Set to 0 to disable caching. Can be increased when usage patterns are better understood.
|
// Set to 0 to disable caching. Can be increased when usage patterns are better understood.
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ By default this command prints the domains configured in the app connector confi
|
|||||||
learned for each domain.
|
learned for each domain.
|
||||||
|
|
||||||
--all prints the routes learned from the domains configured in the app connector configuration; and any extra routes provided
|
--all prints the routes learned from the domains configured in the app connector configuration; and any extra routes provided
|
||||||
in the the policy app connector 'routes' field.
|
in the policy app connector 'routes' field.
|
||||||
|
|
||||||
--map prints the routes learned from the domains configured in the app connector configuration.
|
--map prints the routes learned from the domains configured in the app connector configuration.
|
||||||
|
|
||||||
|
|||||||
@@ -386,7 +386,7 @@ func runTailnetLockRemove(ctx context.Context, args []string) error {
|
|||||||
if isatty.IsTerminal(os.Stdout.Fd()) {
|
if isatty.IsTerminal(os.Stdout.Fd()) {
|
||||||
fmt.Printf(`Warning
|
fmt.Printf(`Warning
|
||||||
Removal of a signing key(s) without resigning nodes (--re-sign=false)
|
Removal of a signing key(s) without resigning nodes (--re-sign=false)
|
||||||
will cause any nodes signed by the the given key(s) to be locked out
|
will cause any nodes signed by the given key(s) to be locked out
|
||||||
of the Tailscale network. Proceed with caution.
|
of the Tailscale network. Proceed with caution.
|
||||||
`)
|
`)
|
||||||
if !prompt.YesNo("Are you sure you want to remove the signing key(s)?", true) {
|
if !prompt.YesNo("Are you sure you want to remove the signing key(s)?", true) {
|
||||||
|
|||||||
+1
-1
@@ -1403,7 +1403,7 @@ func readUint64(r io.Reader) (uint64, error) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// rsaPrivateKeyJSONWrapper is the the JSON serialization
|
// rsaPrivateKeyJSONWrapper is the JSON serialization
|
||||||
// format used by RSAPrivateKey.
|
// format used by RSAPrivateKey.
|
||||||
type rsaPrivateKeyJSONWrapper struct {
|
type rsaPrivateKeyJSONWrapper struct {
|
||||||
Key string
|
Key string
|
||||||
|
|||||||
@@ -25,7 +25,7 @@ type Knobs struct {
|
|||||||
// the client port.
|
// the client port.
|
||||||
RandomizeClientPort atomic.Bool
|
RandomizeClientPort atomic.Bool
|
||||||
|
|
||||||
// OneCGNAT is whether the the node should make one big CGNAT route
|
// OneCGNAT is whether the node should make one big CGNAT route
|
||||||
// in the OS rather than one /32 per peer.
|
// in the OS rather than one /32 per peer.
|
||||||
OneCGNAT syncs.AtomicValue[opt.Bool]
|
OneCGNAT syncs.AtomicValue[opt.Bool]
|
||||||
|
|
||||||
|
|||||||
@@ -323,7 +323,7 @@ func TestSetUnhealthyWithTimeToVisible(t *testing.T) {
|
|||||||
// after mw.TimeToVisible / 2.
|
// after mw.TimeToVisible / 2.
|
||||||
}
|
}
|
||||||
|
|
||||||
// Advance time to get past the the TimeToVisible duration.
|
// Advance time to get past the TimeToVisible duration.
|
||||||
// The watcher should be notified of the unhealthy state.
|
// The watcher should be notified of the unhealthy state.
|
||||||
clock.Advance(mw.TimeToVisible/2 + 1)
|
clock.Advance(mw.TimeToVisible/2 + 1)
|
||||||
<-becameUnhealthy
|
<-becameUnhealthy
|
||||||
@@ -340,7 +340,7 @@ func TestSetUnhealthyWithTimeToVisible(t *testing.T) {
|
|||||||
ht.SetUnhealthy(mw, Args{ArgError: "Hello world"})
|
ht.SetUnhealthy(mw, Args{ArgError: "Hello world"})
|
||||||
ht.SetHealthy(mw)
|
ht.SetHealthy(mw)
|
||||||
|
|
||||||
// Advance to get past the the TimeToVisible delay.
|
// Advance to get past the TimeToVisible delay.
|
||||||
clock.Advance(mw.TimeToVisible * 2)
|
clock.Advance(mw.TimeToVisible * 2)
|
||||||
synctest.Wait()
|
synctest.Wait()
|
||||||
|
|
||||||
@@ -577,7 +577,7 @@ func TestNoDERPHomeWarnable(t *testing.T) {
|
|||||||
clock.Advance(30 * time.Second)
|
clock.Advance(30 * time.Second)
|
||||||
ht.updateBuiltinWarnablesLocked()
|
ht.updateBuiltinWarnablesLocked()
|
||||||
|
|
||||||
// Advance to get past the the TimeToVisible delay.
|
// Advance to get past the TimeToVisible delay.
|
||||||
clock.Advance(noDERPHomeWarnable.TimeToVisible * 2)
|
clock.Advance(noDERPHomeWarnable.TimeToVisible * 2)
|
||||||
|
|
||||||
ht.updateBuiltinWarnablesLocked()
|
ht.updateBuiltinWarnablesLocked()
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
// featureName is the name of the feature implemented by this package.
|
// featureName is the name of the feature implemented by this package.
|
||||||
// It is also the the [desktopSessionsExt] name and the log prefix.
|
// It is also the [desktopSessionsExt] name and the log prefix.
|
||||||
const featureName = "desktop-sessions"
|
const featureName = "desktop-sessions"
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
|
|||||||
@@ -8377,7 +8377,7 @@ func (f *fakeAttestationKey) Clone() key.HardwareAttestationKey {
|
|||||||
// TestStripKeysFromPrefs tests that LocalBackend's [stripKeysFromPrefs] (as used
|
// TestStripKeysFromPrefs tests that LocalBackend's [stripKeysFromPrefs] (as used
|
||||||
// by sendNotify etc) correctly removes all private keys from an ipn.Notify.
|
// by sendNotify etc) correctly removes all private keys from an ipn.Notify.
|
||||||
//
|
//
|
||||||
// It does so by testing the the two ways that Notifys are sent: via sendNotify,
|
// It does so by testing the two ways that Notifys are sent: via sendNotify,
|
||||||
// and via extension hooks.
|
// and via extension hooks.
|
||||||
func TestStripKeysFromPrefs(t *testing.T) {
|
func TestStripKeysFromPrefs(t *testing.T) {
|
||||||
// genNotify generates a sample ipn.Notify with various private keys set
|
// genNotify generates a sample ipn.Notify with various private keys set
|
||||||
|
|||||||
@@ -1247,7 +1247,7 @@ func TestEngineReconfigOnStateChange(t *testing.T) {
|
|||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "Initial",
|
name: "Initial",
|
||||||
// The configs are nil until the the LocalBackend is started.
|
// The configs are nil until the LocalBackend is started.
|
||||||
wantState: ipn.NoState,
|
wantState: ipn.NoState,
|
||||||
wantCfg: nil,
|
wantCfg: nil,
|
||||||
wantRouterCfg: nil,
|
wantRouterCfg: nil,
|
||||||
|
|||||||
@@ -66,7 +66,7 @@ func (o *options) Sys() *tsd.System {
|
|||||||
|
|
||||||
// Backend returns the [ipnlocal.LocalBackend] to be used by the server.
|
// Backend returns the [ipnlocal.LocalBackend] to be used by the server.
|
||||||
// If a backend is provided via [WithBackend], it is used as-is.
|
// If a backend is provided via [WithBackend], it is used as-is.
|
||||||
// Otherwise, a new backend is created with the the [options] in o.
|
// Otherwise, a new backend is created with the [options] in o.
|
||||||
func (o *options) Backend() *ipnlocal.LocalBackend {
|
func (o *options) Backend() *ipnlocal.LocalBackend {
|
||||||
return o.backend.Get(func() *ipnlocal.LocalBackend { return newBackend(o) })
|
return o.backend.Get(func() *ipnlocal.LocalBackend { return newBackend(o) })
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
@@ -973,7 +973,7 @@ func (lg *Logger) appendTextOrJSONLocked(dst, src []byte, level int) []byte {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Check whether the reserved logtail member occurs in the log data.
|
// Check whether the reserved logtail member occurs in the log data.
|
||||||
// If so, it is moved to the the logtail/error member.
|
// If so, it is moved to the logtail/error member.
|
||||||
const jsonSeperators = ",:" // per RFC 8259, section 2
|
const jsonSeperators = ",:" // per RFC 8259, section 2
|
||||||
const jsonWhitespace = " \n\r\t" // per RFC 8259, section 2
|
const jsonWhitespace = " \n\r\t" // per RFC 8259, section 2
|
||||||
var errDetail string
|
var errDetail string
|
||||||
|
|||||||
@@ -85,7 +85,7 @@ func getInterfaceIndex(logf logger.Logf, netMon *netmon.Monitor, address string)
|
|||||||
// Preferentially choose the OS's view of the default if index. Due to the way darwin sets the delegated
|
// Preferentially choose the OS's view of the default if index. Due to the way darwin sets the delegated
|
||||||
// interface on tunnel creation only, it is possible for netmon to have a stale view of the default and
|
// interface on tunnel creation only, it is possible for netmon to have a stale view of the default and
|
||||||
// netmon's view is often temporarily wrong during network transitions, or for us to not have the
|
// netmon's view is often temporarily wrong during network transitions, or for us to not have the
|
||||||
// the the oses view of the defaultIf yet.
|
// the oses view of the defaultIf yet.
|
||||||
if osIferr == nil {
|
if osIferr == nil {
|
||||||
idx = osIf.InterfaceIndex
|
idx = osIf.InterfaceIndex
|
||||||
errOut = nil
|
errOut = nil
|
||||||
|
|||||||
+1
-1
@@ -19,7 +19,7 @@
|
|||||||
// package. The application must template the CSRF token into its forms using
|
// package. The application must template the CSRF token into its forms using
|
||||||
// the [TemplateField] and [TemplateTag] APIs. Applications that are served in a
|
// the [TemplateField] and [TemplateTag] APIs. Applications that are served in a
|
||||||
// secure context (over HTTPS) should also set the SecureContext field to true
|
// secure context (over HTTPS) should also set the SecureContext field to true
|
||||||
// to ensure that the the CSRF cookies are marked as Secure.
|
// to ensure that the CSRF cookies are marked as Secure.
|
||||||
//
|
//
|
||||||
// In addition, browser routes will also have the following applied:
|
// In addition, browser routes will also have the following applied:
|
||||||
// - Content-Security-Policy header that disallows inline scripts, framing, and third party resources.
|
// - Content-Security-Policy header that disallows inline scripts, framing, and third party resources.
|
||||||
|
|||||||
@@ -232,7 +232,7 @@ type Injector struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// NewInjector constructs an [Injector] that can be used to inject events into
|
// NewInjector constructs an [Injector] that can be used to inject events into
|
||||||
// the the stream of events used by code under test. After construction the
|
// the stream of events used by code under test. After construction the
|
||||||
// caller may use [Inject] to insert events into the bus.
|
// caller may use [Inject] to insert events into the bus.
|
||||||
func NewInjector(t *testing.T, b *eventbus.Bus) *Injector {
|
func NewInjector(t *testing.T, b *eventbus.Bus) *Injector {
|
||||||
inj := &Injector{
|
inj := &Injector{
|
||||||
|
|||||||
@@ -212,7 +212,7 @@ func getSvcTriggerInfo(svc *mgr.Service) (*_SERVICE_TRIGGER_INFO, error) {
|
|||||||
|
|
||||||
// makeLogEntry consolidates relevant service information into a svcStateLogEntry.
|
// makeLogEntry consolidates relevant service information into a svcStateLogEntry.
|
||||||
// We record the values of various service configuration constants as strings
|
// We record the values of various service configuration constants as strings
|
||||||
// so the the log entries are easy to interpret at a glance by humans.
|
// so the log entries are easy to interpret at a glance by humans.
|
||||||
func makeLogEntry(svc *mgr.Service, status svc.Status, cfg mgr.Config) (entry svcStateLogEntry) {
|
func makeLogEntry(svc *mgr.Service, status svc.Status, cfg mgr.Config) (entry svcStateLogEntry) {
|
||||||
entry.ServiceName = svc.Name
|
entry.ServiceName = svc.Name
|
||||||
|
|
||||||
|
|||||||
@@ -577,7 +577,7 @@ func lookupPseudoUser(uid string) (*user.User, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// We're looking for SIDs "S-1-5-x" where 17 <= x <= 20.
|
// We're looking for SIDs "S-1-5-x" where 17 <= x <= 20.
|
||||||
// This is checking for the the "5"
|
// This is checking for the "5"
|
||||||
if sid.IdentifierAuthority() != windows.SECURITY_NT_AUTHORITY {
|
if sid.IdentifierAuthority() != windows.SECURITY_NT_AUTHORITY {
|
||||||
return nil, fmt.Errorf(`SID %q does not use "NT AUTHORITY"`, uid)
|
return nil, fmt.Errorf(`SID %q does not use "NT AUTHORITY"`, uid)
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user