all: use Go 1.26 things, run most gofix modernizers

I omitted a lot of the min/max modernizers because they didn't
result in more clear code.

Some of it's older "for x := range 123".

Also: errors.AsType, any, fmt.Appendf, etc.

Updates #18682

Change-Id: I83a451577f33877f962766a5b65ce86f7696471c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2026-03-05 21:13:57 +00:00
committed by Brad Fitzpatrick
parent 4453cc5f53
commit bd2a2d53d3
168 changed files with 431 additions and 618 deletions
+14 -18
View File
@@ -128,7 +128,7 @@ func BenchmarkEncode(b *testing.B) {
b.Run(bb.name, func(b *testing.B) {
b.ReportAllocs()
b.SetBytes(int64(len(src)))
for range b.N {
for b.Loop() {
dst = AppendEncode(dst[:0], src, bb.opts...)
}
})
@@ -153,7 +153,7 @@ func BenchmarkDecode(b *testing.B) {
b.Run(bb.name, func(b *testing.B) {
b.ReportAllocs()
b.SetBytes(int64(len(src)))
for range b.N {
for b.Loop() {
dst = must.Get(AppendDecode(dst[:0], src, bb.opts...))
}
})
@@ -169,16 +169,14 @@ func BenchmarkEncodeParallel(b *testing.B) {
}
b.Run(coder.name, func(b *testing.B) {
b.ReportAllocs()
for range b.N {
var group sync.WaitGroup
for j := 0; j < numCPU; j++ {
group.Add(1)
go func(j int) {
defer group.Done()
for b.Loop() {
var wg sync.WaitGroup
for j := range numCPU {
wg.Go(func() {
dsts[j] = coder.appendEncode(dsts[j][:0], src)
}(j)
})
}
group.Wait()
wg.Wait()
}
})
}
@@ -194,16 +192,14 @@ func BenchmarkDecodeParallel(b *testing.B) {
}
b.Run(coder.name, func(b *testing.B) {
b.ReportAllocs()
for range b.N {
var group sync.WaitGroup
for j := 0; j < numCPU; j++ {
group.Add(1)
go func(j int) {
defer group.Done()
for b.Loop() {
var wg sync.WaitGroup
for j := range numCPU {
wg.Go(func() {
dsts[j] = must.Get(coder.appendDecode(dsts[j][:0], src))
}(j)
})
}
group.Wait()
wg.Wait()
}
})
}