all: use Go 1.26 things, run most gofix modernizers

I omitted a lot of the min/max modernizers because they didn't
result in more clear code.

Some of it's older "for x := range 123".

Also: errors.AsType, any, fmt.Appendf, etc.

Updates #18682

Change-Id: I83a451577f33877f962766a5b65ce86f7696471c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2026-03-05 21:13:57 +00:00
committed by Brad Fitzpatrick
parent 4453cc5f53
commit bd2a2d53d3
168 changed files with 431 additions and 618 deletions
+3 -3
View File
@@ -94,12 +94,12 @@ func TestPool(t *testing.T) {
func TestTakeRandom(t *testing.T) {
p := Pool[int]{}
for i := 0; i < 10; i++ {
for i := range 10 {
p.Add(i + 100)
}
seen := make(map[int]bool)
for i := 0; i < 10; i++ {
for range 10 {
item, ok := p.TakeRandom()
if !ok {
t.Errorf("unexpected empty pool")
@@ -116,7 +116,7 @@ func TestTakeRandom(t *testing.T) {
t.Errorf("expected empty pool")
}
for i := 0; i < 10; i++ {
for i := range 10 {
want := 100 + i
if !seen[want] {
t.Errorf("item %v not seen", want)