all: use Go 1.26 things, run most gofix modernizers

I omitted a lot of the min/max modernizers because they didn't
result in more clear code.

Some of it's older "for x := range 123".

Also: errors.AsType, any, fmt.Appendf, etc.

Updates #18682

Change-Id: I83a451577f33877f962766a5b65ce86f7696471c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2026-03-05 21:13:57 +00:00
committed by Brad Fitzpatrick
parent 4453cc5f53
commit bd2a2d53d3
168 changed files with 431 additions and 618 deletions
+6 -12
View File
@@ -145,13 +145,11 @@ func TestDeferredInit(t *testing.T) {
// Call [DeferredInit.Do] concurrently.
const N = 10000
for range N {
wg.Add(1)
go func() {
wg.Go(func() {
gotErr := di.Do()
checkError(t, gotErr, nil, false)
checkCalls()
wg.Done()
}()
})
}
wg.Wait()
})
@@ -193,12 +191,10 @@ func TestDeferredErr(t *testing.T) {
var wg sync.WaitGroup
N := 10000
for range N {
wg.Add(1)
go func() {
wg.Go(func() {
gotErr := di.Do()
checkError(t, gotErr, tt.wantErr, false)
wg.Done()
}()
})
}
wg.Wait()
})
@@ -254,11 +250,9 @@ func TestDeferAfterDo(t *testing.T) {
const N = 10000
var wg sync.WaitGroup
for range N {
wg.Add(1)
go func() {
wg.Go(func() {
deferOnce()
wg.Done()
}()
})
}
if err := di.Do(); err != nil {