all: use Go 1.26 things, run most gofix modernizers

I omitted a lot of the min/max modernizers because they didn't
result in more clear code.

Some of it's older "for x := range 123".

Also: errors.AsType, any, fmt.Appendf, etc.

Updates #18682

Change-Id: I83a451577f33877f962766a5b65ce86f7696471c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2026-03-05 21:13:57 +00:00
committed by Brad Fitzpatrick
parent 4453cc5f53
commit bd2a2d53d3
168 changed files with 431 additions and 618 deletions
+2 -2
View File
@@ -85,7 +85,7 @@ func (m *monitor) handleSummaryStatus(w http.ResponseWriter, r *http.Request) {
lines = append(lines, fmt.Sprintf("%s\t\t%d\t%d\t%t", name, p.RxBytes, p.TxBytes, p.Active))
}
}
_, err = w.Write([]byte(fmt.Sprintf("RaftState: %s\n", s.RaftState)))
_, err = w.Write(fmt.Appendf(nil, "RaftState: %s\n", s.RaftState))
if err != nil {
log.Printf("monitor: error writing status: %v", err)
return
@@ -93,7 +93,7 @@ func (m *monitor) handleSummaryStatus(w http.ResponseWriter, r *http.Request) {
slices.Sort(lines)
for _, ln := range lines {
_, err = w.Write([]byte(fmt.Sprintf("%s\n", ln)))
_, err = w.Write(fmt.Appendf(nil, "%s\n", ln))
if err != nil {
log.Printf("monitor: error writing status: %v", err)
return