webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

wgengine: fix TSMP/ICMP callback leak

Browse Source 
Fixes #18112

Change-Id: I85d5c482b01673799d51faeb6cb0579903597502
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2025-12-02 10:16:35 -08:00
committed by Brad Fitzpatrick
parent 536188c1b5
commit b8c58ca7c1
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wgengine/userspace.go
+2
View File
@@ -451,6 +451,7 @@ func NewUserspaceEngine(logf logger.Logf, conf Config) (_ Engine, reterr error)
cb := e.pongCallback[pong.Data] cb := e.pongCallback[pong.Data]
e.logf("wgengine: got TSMP pong %02x, peerAPIPort=%v; cb=%v", pong.Data, pong.PeerAPIPort, cb != nil) e.logf("wgengine: got TSMP pong %02x, peerAPIPort=%v; cb=%v", pong.Data, pong.PeerAPIPort, cb != nil)
if cb != nil { if cb != nil {
delete(e.pongCallback, pong.Data)
go cb(pong) go cb(pong)
} }
} }
@@ -464,6 +465,7 @@ func NewUserspaceEngine(logf logger.Logf, conf Config) (_ Engine, reterr error)
// We didn't swallow it, so let it flow to the host. // We didn't swallow it, so let it flow to the host.
return false return false
} }
delete(e.icmpEchoResponseCallback, idSeq)
e.logf("wgengine: got diagnostic ICMP response %02x", idSeq) e.logf("wgengine: got diagnostic ICMP response %02x", idSeq)
go cb() go cb()
return true return true