all: fix typos where we repeat repeat ourselves
Found with the regex `\b([A-Za-z]+) \1\b`. Updates #cleanup Change-Id: I4cc51784d9b6437d3d0c66b531828707f87f7fd5 Signed-off-by: Alex Chan <alexc@tailscale.com>
This commit is contained in:
@@ -148,7 +148,7 @@ type tailnetLockEnabledStatusV1 struct {
|
|||||||
TrustedKeys []tkaKeyV1
|
TrustedKeys []tkaKeyV1
|
||||||
|
|
||||||
// VisiblePeers describes peers which are visible in the netmap that
|
// VisiblePeers describes peers which are visible in the netmap that
|
||||||
// have valid Tailnet Lock signatures signatures.
|
// have valid Tailnet Lock signatures.
|
||||||
VisiblePeers []tkaTrustedPeerV1
|
VisiblePeers []tkaTrustedPeerV1
|
||||||
|
|
||||||
// FilteredPeers describes peers which were removed from the netmap
|
// FilteredPeers describes peers which were removed from the netmap
|
||||||
|
|||||||
@@ -123,7 +123,7 @@ func installSystemDaemonDarwin(args []string) (err error) {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
// Do not overwrite targetBin with the binary file if it it's already
|
// Do not overwrite targetBin with the binary file if it's already
|
||||||
// pointing to it. This is primarily to handle Homebrew that writes
|
// pointing to it. This is primarily to handle Homebrew that writes
|
||||||
// /usr/local/bin/tailscaled is a symlink to the actual binary.
|
// /usr/local/bin/tailscaled is a symlink to the actual binary.
|
||||||
if !same {
|
if !same {
|
||||||
|
|||||||
@@ -789,7 +789,7 @@ func main() {
|
|||||||
for tr := range ch {
|
for tr := range ch {
|
||||||
// Go assigns the package name "command-line-arguments" when you
|
// Go assigns the package name "command-line-arguments" when you
|
||||||
// `go test FILE` rather than `go test PKG`. It's more
|
// `go test FILE` rather than `go test PKG`. It's more
|
||||||
// convenient for us to to specify files in tests, so fix tr.pkg
|
// convenient for us to specify files in tests, so fix tr.pkg
|
||||||
// so that subsequent testwrapper attempts run correctly.
|
// so that subsequent testwrapper attempts run correctly.
|
||||||
if tr.pkg == "command-line-arguments" {
|
if tr.pkg == "command-line-arguments" {
|
||||||
tr.pkg = packages[0]
|
tr.pkg = packages[0]
|
||||||
|
|||||||
+1
-1
@@ -39,7 +39,7 @@ geographic regions to make sure users have low latency to their DERP home.
|
|||||||
Regions generally have multiple nodes per region "meshed" (routing to each
|
Regions generally have multiple nodes per region "meshed" (routing to each
|
||||||
other) together for redundancy: it allows for cloud failures or upgrades without
|
other) together for redundancy: it allows for cloud failures or upgrades without
|
||||||
kicking users out to a higher latency region. Instead, clients will reconnect to
|
kicking users out to a higher latency region. Instead, clients will reconnect to
|
||||||
the next node in the region. Each node in the region is required to to be meshed
|
the next node in the region. Each node in the region is required to be meshed
|
||||||
with every other node in the region and forward packets to the other nodes in
|
with every other node in the region and forward packets to the other nodes in
|
||||||
the region. Packets are forwarded only one hop within the region. There is no
|
the region. Packets are forwarded only one hop within the region. There is no
|
||||||
routing between regions. The assumption is that the mesh TCP connections are
|
routing between regions. The assumption is that the mesh TCP connections are
|
||||||
|
|||||||
+1
-1
@@ -69,7 +69,7 @@ type clientOpt struct {
|
|||||||
func MeshKey(k key.DERPMesh) ClientOpt { return clientOptFunc(func(o *clientOpt) { o.MeshKey = k }) }
|
func MeshKey(k key.DERPMesh) ClientOpt { return clientOptFunc(func(o *clientOpt) { o.MeshKey = k }) }
|
||||||
|
|
||||||
// IsProber returns a ClientOpt to pass to the DERP server during connect to
|
// IsProber returns a ClientOpt to pass to the DERP server during connect to
|
||||||
// declare that this client is a a prober.
|
// declare that this client is a prober.
|
||||||
func IsProber(v bool) ClientOpt { return clientOptFunc(func(o *clientOpt) { o.IsProber = v }) }
|
func IsProber(v bool) ClientOpt { return clientOptFunc(func(o *clientOpt) { o.IsProber = v }) }
|
||||||
|
|
||||||
// ServerPublicKey returns a ClientOpt to declare that the server's DERP public key is known.
|
// ServerPublicKey returns a ClientOpt to declare that the server's DERP public key is known.
|
||||||
|
|||||||
@@ -784,7 +784,7 @@ func (b *LocalBackend) onHomeDERPUpdate(du magicsock.HomeDERPChanged) {
|
|||||||
// In practice, it is possible that one profile with a homeDERP of 0 (no-derp)
|
// In practice, it is possible that one profile with a homeDERP of 0 (no-derp)
|
||||||
// got switched before setting any home DERP or that DERP IDs match across
|
// got switched before setting any home DERP or that DERP IDs match across
|
||||||
// DERP maps. Since the risk of this happening is small and the consequences
|
// DERP maps. Since the risk of this happening is small and the consequences
|
||||||
// of this is is just a possible less optimal DERP until the next reSTUN,
|
// of this is just a possible less optimal DERP until the next reSTUN,
|
||||||
// accept this possibility.
|
// accept this possibility.
|
||||||
func (b *LocalBackend) onHomeDERPUpdateLocked(du magicsock.HomeDERPChanged) {
|
func (b *LocalBackend) onHomeDERPUpdateLocked(du magicsock.HomeDERPChanged) {
|
||||||
cn := b.currentNode()
|
cn := b.currentNode()
|
||||||
|
|||||||
@@ -8301,7 +8301,7 @@ func TestDisplayMessageIPNBus(t *testing.T) {
|
|||||||
if ok {
|
if ok {
|
||||||
if diff := cmp.Diff(tt.wantWarning, got, cmpopts.IgnoreFields(health.UnhealthyState{}, "ETag")); diff != "" {
|
if diff := cmp.Diff(tt.wantWarning, got, cmpopts.IgnoreFields(health.UnhealthyState{}, "ETag")); diff != "" {
|
||||||
t.Errorf("unexpected warning details (-want/+got):\n%s", diff)
|
t.Errorf("unexpected warning details (-want/+got):\n%s", diff)
|
||||||
return true // we failed the test so tell the watcher we've seen what we need to to stop it waiting
|
return true // we failed the test so tell the watcher we've seen what we need to stop it waiting
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
got := slices.Collect(maps.Keys(n.Health.Warnings))
|
got := slices.Collect(maps.Keys(n.Health.Warnings))
|
||||||
|
|||||||
@@ -137,7 +137,7 @@ type TailnetLockStatus struct {
|
|||||||
TrustedKeys []TKAKey
|
TrustedKeys []TKAKey
|
||||||
|
|
||||||
// VisiblePeers describes peers which are visible in the netmap that
|
// VisiblePeers describes peers which are visible in the netmap that
|
||||||
// have valid Tailnet Lock signatures signatures.
|
// have valid Tailnet Lock signatures.
|
||||||
VisiblePeers []*TKAPeer
|
VisiblePeers []*TKAPeer
|
||||||
|
|
||||||
// FilteredPeers describes peers which were removed from the netmap
|
// FilteredPeers describes peers which were removed from the netmap
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ func (h *Handler) serveCert(w http.ResponseWriter, r *http.Request) {
|
|||||||
pair, err := h.b.GetCertPEMWithValidity(r.Context(), domain, minValidity)
|
pair, err := h.b.GetCertPEMWithValidity(r.Context(), domain, minValidity)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
// TODO(bradfitz): 500 is a little lazy here. The errors returned from
|
// TODO(bradfitz): 500 is a little lazy here. The errors returned from
|
||||||
// GetCertPEM (and everywhere) should carry info info to get whether
|
// GetCertPEM (and everywhere) should carry info to get whether
|
||||||
// they're 400 vs 403 vs 500 at minimum. And then we should have helpers
|
// they're 400 vs 403 vs 500 at minimum. And then we should have helpers
|
||||||
// (in tsweb probably) to return an error that looks at the error value
|
// (in tsweb probably) to return an error that looks at the error value
|
||||||
// to determine the HTTP status code.
|
// to determine the HTTP status code.
|
||||||
|
|||||||
@@ -79,7 +79,7 @@ type awsStore struct {
|
|||||||
//
|
//
|
||||||
// Note that we store the entire store in a single parameter
|
// Note that we store the entire store in a single parameter
|
||||||
// key, therefore if the state is above 8kb, it can cause
|
// key, therefore if the state is above 8kb, it can cause
|
||||||
// Tailscaled to only only store new state in-memory and
|
// Tailscaled to only store new state in-memory and
|
||||||
// restarting Tailscaled can fail until you delete your state
|
// restarting Tailscaled can fail until you delete your state
|
||||||
// from the AWS Parameter Store.
|
// from the AWS Parameter Store.
|
||||||
//
|
//
|
||||||
|
|||||||
@@ -1349,8 +1349,7 @@ func (f *forwarder) forwardWithDestChan(ctx context.Context, query packet, respo
|
|||||||
|
|
||||||
// If we haven't got an error or a successful response,
|
// If we haven't got an error or a successful response,
|
||||||
// include all resolvers in the error message so we can
|
// include all resolvers in the error message so we can
|
||||||
// at least see what what servers we're trying to
|
// at least see what servers we're trying to query.
|
||||||
// query.
|
|
||||||
var resolverAddrs []string
|
var resolverAddrs []string
|
||||||
for _, rr := range resolvers {
|
for _, rr := range resolvers {
|
||||||
resolverAddrs = append(resolverAddrs, rr.name.Addr)
|
resolverAddrs = append(resolverAddrs, rr.name.Addr)
|
||||||
|
|||||||
@@ -267,7 +267,7 @@ func (cd *ChangeDelta) AnyInterfaceUp() bool {
|
|||||||
|
|
||||||
// isInterestingInterfaceChange reports whether any interfaces have changed in a meaningful way.
|
// isInterestingInterfaceChange reports whether any interfaces have changed in a meaningful way.
|
||||||
// This excludes interfaces that are not interesting per IsInterestingInterface and
|
// This excludes interfaces that are not interesting per IsInterestingInterface and
|
||||||
// filters out changes to interface IPs that that are uninteresting (e.g. link-local addresses).
|
// filters out changes to interface IPs that are uninteresting (e.g. link-local addresses).
|
||||||
func (cd *ChangeDelta) isInterestingInterfaceChange() bool {
|
func (cd *ChangeDelta) isInterestingInterfaceChange() bool {
|
||||||
// If there is no old state, everything is considered changed.
|
// If there is no old state, everything is considered changed.
|
||||||
if cd.old == nil {
|
if cd.old == nil {
|
||||||
|
|||||||
@@ -45,7 +45,7 @@ type HeaderChecksummer interface {
|
|||||||
Header
|
Header
|
||||||
|
|
||||||
// WriteCheck writes the correct checksum into buf, which should
|
// WriteCheck writes the correct checksum into buf, which should
|
||||||
// be be the already-marshalled header and payload.
|
// be the already-marshalled header and payload.
|
||||||
WriteChecksum(buf []byte)
|
WriteChecksum(buf []byte)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -13,7 +13,7 @@ import (
|
|||||||
// is either "true", "false", or the empty string to mean unset.
|
// is either "true", "false", or the empty string to mean unset.
|
||||||
//
|
//
|
||||||
// As a special case, the underlying string may also be the string
|
// As a special case, the underlying string may also be the string
|
||||||
// "unset" as as a synonym for the empty string. This lets the
|
// "unset" as a synonym for the empty string. This lets the
|
||||||
// explicit unset value be exchanged over an encoding/json "omitempty"
|
// explicit unset value be exchanged over an encoding/json "omitempty"
|
||||||
// field without it being dropped.
|
// field without it being dropped.
|
||||||
type Bool string
|
type Bool string
|
||||||
|
|||||||
@@ -1020,7 +1020,7 @@ func (e *userspaceEngine) Reconfig(cfg *wgcfg.Config, routerCfg *router.Config,
|
|||||||
}
|
}
|
||||||
|
|
||||||
// We've historically re-set DNS even after just a router change. While
|
// We've historically re-set DNS even after just a router change. While
|
||||||
// refactoring in tailscale/tailscale#17448 and and
|
// refactoring in tailscale/tailscale#17448 and
|
||||||
// tailscale/tailscale#17499, I'm erring on the side of keeping that
|
// tailscale/tailscale#17499, I'm erring on the side of keeping that
|
||||||
// historical quirk for now (2025-10-08), lest it's load bearing in
|
// historical quirk for now (2025-10-08), lest it's load bearing in
|
||||||
// unexpected ways
|
// unexpected ways
|
||||||
|
|||||||
Reference in New Issue
Block a user