tstime: add Parse3339B, for byte slices

Use go4.org/mem for memory safety.
A slight performance hit, but a huge performance win
for clients who start with a []byte.
The perf hit is due largely to the MapHash call, which adds ~25ns.
That is necessary to keep the fast path allocation-free.

name                     old time/op    new time/op    delta
GoParse3339/Z-8             281ns ± 1%     283ns ± 2%     ~     (p=0.366 n=9+9)
GoParse3339/TZ-8            509ns ± 0%     510ns ± 1%     ~     (p=0.059 n=9+9)
GoParse3339InLocation-8     330ns ± 1%     330ns ± 0%     ~     (p=0.802 n=10+6)
Parse3339/Z-8              69.3ns ± 1%    74.4ns ± 1%   +7.45%  (p=0.000 n=9+10)
Parse3339/TZ-8              110ns ± 1%     140ns ± 3%  +27.42%  (p=0.000 n=9+10)
ParseInt-8                 8.20ns ± 1%    8.17ns ± 1%     ~     (p=0.452 n=9+9)

name                     old alloc/op   new alloc/op   delta
GoParse3339/Z-8             0.00B          0.00B          ~     (all equal)
GoParse3339/TZ-8             160B ± 0%      160B ± 0%     ~     (all equal)
GoParse3339InLocation-8     0.00B          0.00B          ~     (all equal)
Parse3339/Z-8               0.00B          0.00B          ~     (all equal)
Parse3339/TZ-8              0.00B          0.00B          ~     (all equal)

name                     old allocs/op  new allocs/op  delta
GoParse3339/Z-8              0.00           0.00          ~     (all equal)
GoParse3339/TZ-8             3.00 ± 0%      3.00 ± 0%     ~     (all equal)
GoParse3339InLocation-8      0.00           0.00          ~     (all equal)
Parse3339/Z-8                0.00           0.00          ~     (all equal)
Parse3339/TZ-8               0.00           0.00          ~     (all equal)


Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>

This commit is contained in:

Josh Bleecher Snyder

2020-11-18 11:59:02 -08:00

committed by

Josh Bleecher Snyder

parent a5dd0bcb09

commit aa9d7f4665

6 changed files with 81 additions and 54 deletions

									
										go.mod
									
		+1
		-1
	
												View File
												
				@@ -26,7 +26,7 @@ require (

					github.com/tailscale/wireguard-go v0.0.0-20201021041318-a6168fd06b3f

					github.com/tcnksm/go-httpstat v0.2.0

					github.com/toqueteos/webbrowser v1.2.0

					go4.org/mem v0.0.0-20200706164138-185c595c3ecc

					go4.org/mem v0.0.0-20201119185036-c04c5a6ff174

					golang.org/x/crypto v0.0.0-20201112155050-0c6587e931a9

					golang.org/x/net v0.0.0-20201110031124-69a78807bb2b

					golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d