kube/certs: discover TLS domains from TCP TerminateTLS handlers (#19020)

After #18179 switched to L4 TCPForward, EnsureCertLoops found no
domains since it only checked service.Web entries. Certs were never
provisioned, leaving kube-apiserver ProxyGroups stuck at 0/N ready.

Fixes #19019

Signed-off-by: Raj Singh <raj@tailscale.com>
This commit is contained in:
Raj Singh
2026-03-17 12:35:39 -05:00
committed by GitHub
parent b3c6184f9f
commit a565833998
2 changed files with 45 additions and 0 deletions
+38
View File
@@ -127,6 +127,43 @@ func TestEnsureCertLoops(t *testing.T) {
initialGoroutines: 2, // initially two loops (one per service)
updatedGoroutines: 1, // one loop after removing service2
},
{
name: "tcp_terminate_tls",
initialConfig: &ipn.ServeConfig{
Services: map[tailcfg.ServiceName]*ipn.ServiceConfig{
"svc:my-apiserver": {
TCP: map[uint16]*ipn.TCPPortHandler{
443: {
TCPForward: "localhost:80",
TerminateTLS: "my-apiserver.tailnetxyz.ts.net",
},
},
},
},
},
initialGoroutines: 1,
},
{
name: "tcp_terminate_tls_and_web",
initialConfig: &ipn.ServeConfig{
Services: map[tailcfg.ServiceName]*ipn.ServiceConfig{
"svc:my-apiserver": {
TCP: map[uint16]*ipn.TCPPortHandler{
443: {
TCPForward: "localhost:80",
TerminateTLS: "my-apiserver.tailnetxyz.ts.net",
},
},
},
"svc:my-app": {
Web: map[ipn.HostPort]*ipn.WebServerConfig{
"my-app.tailnetxyz.ts.net:443": {},
},
},
},
},
initialGoroutines: 2,
},
{
name: "add_domain",
initialConfig: &ipn.ServeConfig{
@@ -171,6 +208,7 @@ func TestEnsureCertLoops(t *testing.T) {
CertDomains: []string{
"my-app.tailnetxyz.ts.net",
"my-other-app.tailnetxyz.ts.net",
"my-apiserver.tailnetxyz.ts.net",
},
},
},