webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

client/systray: add missing deferred unlock for httpCache mutex

Browse Source 
Updates #cleanup

Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d
Signed-off-by: Will Norris <will@tailscale.com>
This commit is contained in:
Will Norris
2025-12-15 08:20:45 -08:00
committed by Will Norris
parent d0d993f5d6
commit 951d711054
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/systray/systray.go
+1 -1
View File
@@ -372,6 +372,7 @@ func setRemoteIcon(menu *systray.MenuItem, urlStr string) {
} }
cacheMu.Lock() cacheMu.Lock()
defer cacheMu.Unlock()
b, ok := httpCache[urlStr] b, ok := httpCache[urlStr]
if !ok { if !ok {
resp, err := http.Get(urlStr) resp, err := http.Get(urlStr)
@@ -395,7 +396,6 @@ func setRemoteIcon(menu *systray.MenuItem, urlStr string) {
resp.Body.Close() resp.Body.Close()
} }
} }
cacheMu.Unlock()
if len(b) > 0 { if len(b) > 0 {
menu.SetIcon(b) menu.SetIcon(b)