client/web: add eslint

Add eslint to require stricter typescript rules, particularly around
required hook dependencies. This commit also updates any files that
were now throwing errors with eslint.

Updates #10261

Signed-off-by: Sonia Appasamy <sonia@tailscale.com>

client/web/src/components/views/device-details-view.tsx

@@ -125,6 +125,7 @@ export default function DeviceDetailsView({
             // TODO: pipe control serve url from backend
             href="https://login.tailscale.com/admin"
             target="_blank"
+            rel="noreferrer"
             className="text-indigo-700 text-sm"
           >
             this device’s page

client/web/src/components/views/login-view.tsx

@@ -32,7 +32,7 @@ export default function LoginView({
   return (
     <div className="mb-8 py-6 px-8 bg-white rounded-md shadow-2xl">
       <TailscaleIcon className="my-2 mb-8" />
-      {data.Status == "Stopped" ? (
+      {data.Status === "Stopped" ? (
         <>
           <div className="mb-6">
             <h3 className="text-3xl font-semibold mb-3">Connect</h3>
@@ -57,6 +57,7 @@ export default function LoginView({
                 href="https://tailscale.com/kb/1028/key-expiry"
                 className="link"
                 target="_blank"
+                rel="noreferrer"
               >
                 learn more
               </a>
@@ -77,7 +78,12 @@ export default function LoginView({
             <p className="text-gray-700">
               Get started by logging in to your Tailscale network.
               Or,&nbsp;learn&nbsp;more at{" "}
-              <a href="https://tailscale.com/" className="link" target="_blank">
+              <a
+                href="https://tailscale.com/"
+                className="link"
+                target="_blank"
+                rel="noreferrer"
+              >
                 tailscale.com
               </a>
               .
@@ -103,6 +109,7 @@ export default function LoginView({
                 href="https://tailscale.com/kb/1085/auth-keys/"
                 className="link"
                 target="_blank"
+                rel="noreferrer"
               >
                 Learn more &rarr;
               </a>

client/web/src/components/views/ssh-view.tsx

@@ -24,6 +24,7 @@ export default function SSHView({
           href="https://tailscale.com/kb/1193/tailscale-ssh/"
           className="text-indigo-700"
           target="_blank"
+          rel="noreferrer"
         >
           Learn more →
         </a>
@@ -44,6 +45,7 @@ export default function SSHView({
           href="https://login.tailscale.com/admin/acls/"
           className="text-indigo-700"
           target="_blank"
+          rel="noreferrer"
         >
           tailnet policy file
         </a>{" "}