posture: add HealthTracker for serial number retrieval (#19181)
Device posture checking can fail while enabled if tailscaled does not have access to smbios. Previously, this was only observable by looking in the tailscaled logs. Fixes tailscale/corp#39314 Signed-off-by: Evan Lowry <evan@tailscale.com>
This commit is contained in:
@@ -8,8 +8,10 @@ package posture
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
|
||||
"tailscale.com/health"
|
||||
"tailscale.com/ipn/ipnext"
|
||||
"tailscale.com/ipn/ipnlocal"
|
||||
"tailscale.com/posture"
|
||||
@@ -25,6 +27,15 @@ func init() {
|
||||
ipnlocal.RegisterC2N("GET /posture/identity", handleC2NPostureIdentityGet)
|
||||
}
|
||||
|
||||
var postureSerialWarnable = health.Register(&health.Warnable{
|
||||
Code: "posture-checking-serial-collection-failed",
|
||||
Title: "Device Posture: serial number collection failed",
|
||||
Severity: health.SeverityMedium,
|
||||
Text: func(args health.Args) string {
|
||||
return fmt.Sprintf("Could not collect device serial numbers for posture checking. (%v)", args[health.ArgError])
|
||||
},
|
||||
})
|
||||
|
||||
func newExtension(logf logger.Logf, b ipnext.SafeBackend) (ipnext.Extension, error) {
|
||||
e := &extension{
|
||||
logf: logger.WithPrefix(logf, "posture: "),
|
||||
@@ -73,6 +84,9 @@ func handleC2NPostureIdentityGet(b *ipnlocal.LocalBackend, w http.ResponseWriter
|
||||
res.SerialNumbers, err = posture.GetSerialNumbers(b.PolicyClient(), e.logf)
|
||||
if err != nil {
|
||||
e.logf("c2n: GetSerialNumbers returned error: %v", err)
|
||||
b.HealthTracker().SetUnhealthy(postureSerialWarnable, health.Args{health.ArgError: err.Error()})
|
||||
} else {
|
||||
b.HealthTracker().SetHealthy(postureSerialWarnable)
|
||||
}
|
||||
|
||||
// TODO(tailscale/corp#21371, 2024-07-10): once this has landed in a stable release
|
||||
|
||||
Reference in New Issue
Block a user