cmd/k8s-operator,k8s-operator: use default ProxyClass if set for ProxyGroup (#13720)

The default ProxyClass can be set via helm chart or env var, and applies
to all proxies that do not otherwise have an explicit ProxyClass set.
This ensures proxies created by the new ProxyGroup CRD are consistent
with the behaviour of existing proxies

Nearby but unrelated changes:

* Fix up double error logs (controller runtime logs returned errors)
* Fix a couple of variable names

Updates #13406

Signed-off-by: Tom Proctor <tomhjp@users.noreply.github.com>

k8s-operator/apis/v1alpha1/types_connector.go

@@ -171,7 +171,7 @@ type ConditionType string
 
 const (
 	ConnectorReady  ConditionType = `ConnectorReady`
-	ProxyClassready ConditionType = `ProxyClassReady`
+	ProxyClassReady ConditionType = `ProxyClassReady`
 	ProxyGroupReady ConditionType = `ProxyGroupReady`
 	ProxyReady      ConditionType = `TailscaleProxyReady` // a Tailscale-specific condition type for corev1.Service
 	RecorderReady   ConditionType = `RecorderReady`

k8s-operator/apis/v1alpha1/types_proxygroup.go

@@ -64,8 +64,9 @@ type ProxyGroupSpec struct {
 
 	// ProxyClass is the name of the ProxyClass custom resource that contains
 	// configuration options that should be applied to the resources created
-	// for this ProxyGroup. If unset, the operator will create resources with
-	// the default configuration.
+	// for this ProxyGroup. If unset, and there is no default ProxyClass
+	// configured, the operator will create resources with the default
+	// configuration.
 	// +optional
 	ProxyClass string `json:"proxyClass,omitempty"`
 }