webnet/tailscale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

logpolicy: fix nil pointer dereference with invalid TS_LOG_TARGET

Browse Source 
When TS_LOG_TARGET is set to an invalid URL, url.Parse returns an error
and nil pointer, which caused a panic when accessing u.Host.

Now we check the error from url.Parse and log a helpful message while
falling back to the default log host.

Fixes #17792

Signed-off-by: Andrew Dunham <andrew@tailscale.com>
This commit is contained in:
Andrew Dunham
2025-11-14 11:59:09 -05:00
committed by Andrew Dunham
parent 052602752f
commit 208a32af5b
2 changed files with 54 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
logpolicy/logpolicy.go
+10 -4
View File
@@ -640,10 +640,16 @@ func (opts Options) init(disableLogging bool) (*logtail.Config, *Policy) {
logHost := logtail.DefaultHost
if val := getLogTarget(); val != "" {
opts.Logf("You have enabled a non-default log target. Doing without being told to by Tailscale staff or your network administrator will make getting support difficult.")
conf.BaseURL = val
u, _ := url.Parse(val)
logHost = u.Host
u, err := url.Parse(val)
if err != nil {
opts.Logf("logpolicy: invalid TS_LOG_TARGET %q: %v; using default log host", val, err)
} else if u.Host == "" {
opts.Logf("logpolicy: invalid TS_LOG_TARGET %q: missing host; using default log host", val)
} else {
opts.Logf("You have enabled a non-default log target. Doing without being told to by Tailscale staff or your network administrator will make getting support difficult.")
conf.BaseURL = val
logHost = u.Host
}
}
if conf.HTTPC == nil {