all: add (*testing.B).ReportAllocs() to every benchmark
This ensures that we can properly track and catch allocation slippages that could otherwise have been missed. Fixes #2748
This commit is contained in:
committed by
Brad Fitzpatrick
parent
44d71d1e42
commit
0daa32943e
@@ -1194,6 +1194,10 @@ func addTestEndpoint(tb testing.TB, conn *Conn, sendConn net.PacketConn) (tailcf
|
||||
}
|
||||
|
||||
func setUpReceiveFrom(tb testing.TB) (roundTrip func()) {
|
||||
if b, ok := tb.(*testing.B); ok {
|
||||
b.ReportAllocs()
|
||||
}
|
||||
|
||||
conn := newTestConn(tb)
|
||||
tb.Cleanup(func() { conn.Close() })
|
||||
conn.logf = logger.Discard
|
||||
@@ -1295,6 +1299,7 @@ func BenchmarkReceiveFrom(b *testing.B) {
|
||||
}
|
||||
|
||||
func BenchmarkReceiveFrom_Native(b *testing.B) {
|
||||
b.ReportAllocs()
|
||||
recvConn, err := net.ListenPacket("udp4", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
b.Fatal(err)
|
||||
|
||||
@@ -214,6 +214,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
|
||||
lanot := netaddr.MustParseIP("5.5.5.5")
|
||||
var x bool
|
||||
b.Run("map1", func(b *testing.B) {
|
||||
b.ReportAllocs()
|
||||
b.ResetTimer()
|
||||
m := map[netaddr.IP]bool{
|
||||
la1: true,
|
||||
}
|
||||
@@ -223,6 +225,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
|
||||
}
|
||||
})
|
||||
b.Run("map2", func(b *testing.B) {
|
||||
b.ReportAllocs()
|
||||
b.ResetTimer()
|
||||
m := map[netaddr.IP]bool{
|
||||
la1: true,
|
||||
la2: true,
|
||||
@@ -233,6 +237,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
|
||||
}
|
||||
})
|
||||
b.Run("or1", func(b *testing.B) {
|
||||
b.ReportAllocs()
|
||||
b.ResetTimer()
|
||||
f := func(t netaddr.IP) bool {
|
||||
return t == la1
|
||||
}
|
||||
@@ -242,6 +248,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
|
||||
}
|
||||
})
|
||||
b.Run("or2", func(b *testing.B) {
|
||||
b.ReportAllocs()
|
||||
b.ResetTimer()
|
||||
f := func(t netaddr.IP) bool {
|
||||
return t == la1 || t == la2
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user