codinget
  • Joined on 2022-10-19
codinget pushed to t3code/issue-171-entries-method at webnet/webnet 2026-08-04 16:37:04 +02:00
c9ff59bd9a docs(vfs): define overwrite replacement
codinget commented on pull request webnet/webnet#172 2026-08-04 16:27:56 +02:00
vfs: combine stat and directory listing

Re-checked at e00d55d2a. All four findings from review 40 are resolved, and the fixes are the right shape rather than the minimum:

  • SMB2 access escalationdelete() now classifies with…
codinget commented on pull request webnet/webnet#172 2026-08-04 15:51:54 +02:00
vfs: combine stat and directory listing

Fresh autonomous review of e00d55d2a is clean with no actionable findings. The review traced overwrite handling across Drive delegation and every in-repo native copy/move implementation,…

codinget pushed to t3code/issue-171-entries-method at webnet/webnet 2026-08-04 15:50:28 +02:00
e00d55d2af fix(vfs): preserve overwrite destinations
codinget pushed to t3code/issue-171-entries-method at webnet/webnet 2026-08-04 15:44:14 +02:00
a82ddab3a2 fix(drive): preserve overwrite destination
codinget pushed to t3code/issue-171-entries-method at webnet/webnet 2026-08-04 15:39:27 +02:00
e1dc165e03 fix(vfs): address combined metadata review
codinget commented on pull request webnet/webnet#172 2026-08-04 15:17:18 +02:00
vfs: combine stat and directory listing

Autonomous review of t3code/issue-171-entries-method. The shape is right: statAndReaddir is optional, file-or-directory semantics avoid a second call on the stat-then-branch pattern, the conformance additions cover root/empty/file/missing, and the fallback branches are genuinely exercised (PROPFIND Depth:1 falls back when statAndReaddir is absent, and the FTP proxy asserting statAndReaddir === 0 for MLST). The #169 malformed-207 regression survives the rewrite and is now pinned to one request per probe. Four findings, one of which I would fix before merge.

codinget commented on pull request webnet/webnet#172 2026-08-04 03:04:04 +02:00
vfs: combine stat and directory listing

Autonomous code review completed against origin/main...93b2dff94: no actionable findings. The review checked the optional API semantics, intentional Node/FTP/SFTP omissions, DAV and SMB resource…

codinget created pull request webnet/webnet#172 2026-08-04 03:00:22 +02:00
WIP: vfs: combine stat and directory listing
codinget created branch t3code/issue-171-entries-method in webnet/webnet 2026-08-04 03:00:01 +02:00
codinget pushed to t3code/issue-171-entries-method at webnet/webnet 2026-08-04 03:00:01 +02:00
93b2dff943 refactor(vfs): reuse combined directory metadata
e21ad5f24f feat(vfs): combine stat and directory listing
Compare 2 commits »
codinget pushed to main at webnet/webnet 2026-08-04 01:30:41 +02:00
dc613b5dfe refactor(taildrive): clarify discovery exports
a60f1b626e fix(taildrive): harden peer probes
a0ad4bf17b feat(taildrive): discover peers with shares
Compare 3 commits »
codinget deleted branch t3code/taildrive-peer-filtering from webnet/webnet 2026-08-04 01:30:41 +02:00
codinget merged pull request webnet/webnet#169 2026-08-04 01:30:39 +02:00
feat(taildrive): discover peers with shares
codinget commented on pull request webnet/webnet#169 2026-08-04 01:09:20 +02:00
feat(taildrive): discover peers with shares

Addressed both follow-up remarks in dc613b5df:

  • renamed the narrower helper to listDrivePeersWithShares, keeping IpnClient.listDrivePeers unambiguous at call sites;
  • added the conventional…
codinget pushed to t3code/taildrive-peer-filtering at webnet/webnet 2026-08-04 01:09:20 +02:00
dc613b5dfe refactor(taildrive): clarify discovery exports
codinget commented on pull request webnet/webnet#169 2026-08-04 01:03:26 +02:00
feat(taildrive): discover peers with shares

Additional nit: the package now exports ./client and ./server, but doesn't export ., unlike every other package in this monorepo with a client/server split.

codinget commented on pull request webnet/tailscale#19 2026-08-04 00:57:54 +02:00
feat(tsconnect/wasm): add hasShares filter to listDrivePeers

Closing alongside webnet/webnet#166. The webnet-side filtering landed in webnet/webnet#169 instead, implemented in @webnet/taildrive/client over the existing peerAPI /v0/drive path, so the…

codinget closed pull request webnet/tailscale#19 2026-08-04 00:57:54 +02:00
feat(tsconnect/wasm): add hasShares filter to listDrivePeers
codinget commented on pull request webnet/webnet#166 2026-08-04 00:57:23 +02:00
feat(tsconnect): add hasShares option to listDrivePeers

Superseded by #169, which implements the same positive filter entirely in @webnet/taildrive/client with no fork divergence and no listDrivePeers API or worker-RPC change.

The decisive point…