codinget
  • Joined on 2022-10-19
codinget created branch t3code/553a4600 in webnet/webnet 2026-07-12 17:35:48 +02:00
codinget deleted branch feat/transport-upgrade-tls from webnet/webnet 2026-07-12 16:37:57 +02:00
codinget pushed to main at webnet/webnet 2026-07-12 16:37:57 +02:00
59398e8b52 docs: record TLS-upgrade review rounds in AI_CHANGES.md
2555cdd47f fix(transport): make pre-handshake upgrade failures consistent and leak-free
da345d4d58 fix(transport): address neutral-review findings on TLS upgrade
e29e097863 fix(transport): guard read/write during an in-flight TLS upgrade
1689c2eacc feat(transport): add explicit TLS upgrade (STARTTLS / AUTH TLS) to RawTransport
Compare 5 commits »
codinget merged pull request webnet/webnet#63 2026-07-12 16:37:56 +02:00
feat(transport): add explicit TLS upgrade (STARTTLS / AUTH TLS) to RawTransport
codinget pushed to feat/transport-upgrade-tls at webnet/webnet 2026-07-12 16:09:33 +02:00
59398e8b52 docs: record TLS-upgrade review rounds in AI_CHANGES.md
2555cdd47f fix(transport): make pre-handshake upgrade failures consistent and leak-free
da345d4d58 fix(transport): address neutral-review findings on TLS upgrade
e29e097863 fix(transport): guard read/write during an in-flight TLS upgrade
1689c2eacc feat(transport): add explicit TLS upgrade (STARTTLS / AUTH TLS) to RawTransport
Compare 5 commits »
codinget pushed to feat/transport-upgrade-tls at webnet/webnet 2026-07-12 15:30:43 +02:00
a7c301c6ff Merge remote-tracking branch 'origin/main' into feat/transport-upgrade-tls
d60c6d1736 docs: require labels on issues
95ec85db15 docs: clarify scoped checks and CI finalisation
07ca1eaea9 test(ftp): add real-server integration coverage
77041f815f feat(dev): add remote host development mode
Compare 17 commits »
codinget pushed to feat/transport-upgrade-tls at webnet/webnet 2026-07-12 15:13:30 +02:00
62bcb6188c docs: record TLS-upgrade review rounds in AI_CHANGES.md
codinget deleted branch feat/conn-upgrade-tls from webnet/tailscale 2026-07-12 15:11:35 +02:00
codinget pushed to webnet at webnet/tailscale 2026-07-12 15:11:34 +02:00
721194dfb5 fix(tsconnect/wasm): close conn on upgradeTLS configuration errors too
81e37f8812 feat(tsconnect/wasm): add upgradeTLS to wrapped conns
Compare 2 commits »
codinget merged pull request webnet/tailscale#14 2026-07-12 15:11:33 +02:00
feat(tsconnect/wasm): add upgradeTLS to wrapped conns
codinget commented on pull request webnet/webnet#63 2026-07-12 13:29:48 +02:00
feat(transport): add explicit TLS upgrade (STARTTLS / AUTH TLS) to RawTransport

The blocking finding is confirmed and addressed in 4a3caf8 (+ tailscale 721194d). Both legs were real:

Go/wrapper inconsistency: wasm_js.go's upgradeTLS only closed the conn on handshake…

codinget pushed to feat/transport-upgrade-tls at webnet/webnet 2026-07-12 13:29:27 +02:00
4a3caf8a93 fix(transport): make pre-handshake upgrade failures consistent and leak-free
codinget pushed to feat/conn-upgrade-tls at webnet/tailscale 2026-07-12 13:28:36 +02:00
721194dfb5 fix(tsconnect/wasm): close conn on upgradeTLS configuration errors too
codinget pushed to state-transfer at webnet/webnet 2026-07-12 04:44:52 +02:00
a3d74b26cc docs: record state transfer review round in AI_CHANGES.md
codinget commented on pull request webnet/webnet#76 2026-07-12 04:37:02 +02:00
cross-tab state and ownership transfer for tsconnect-worker resources

Both reviews addressed; thanks — the in-flight-accept finding was a genuine ownership-crossing bug.

Blocking finding (in-flight ops crossing ownership) — fixed in 65e780f. Each worker-side…

codinget pushed to state-transfer at webnet/webnet 2026-07-12 04:34:57 +02:00
e13d9257e0 fix(http): prune emptied pool slots on exportIdle
342b57418d fix(drive): close remaining exports when transferState fails mid-loop
8520f03c14 fix(tsconnect-worker): collect nested transfer tokens and fix replay order
65e780fb2e fix(tsconnect-worker): preserve in-flight results across ownership transfer
Compare 4 commits »
codinget commented on pull request webnet/webnet#76 2026-07-12 04:28:15 +02:00
cross-tab state and ownership transfer for tsconnect-worker resources

Autonomous review (Claude Fable 5). Read the full branch against origin/main, focusing on worker.ts, transfers.ts, client.ts, pool.ts, connection.ts and drive/client.ts. The core design is sound: detach never closes the socket (transfers.ts only closes on TTL/cancel), pending transfers survive cleanupClient (they live in the registry, not entry.resources), deferred IPN shutdown via onEmpty -> maybeShutdownIpn is correctly guarded on both clients.size and hasPending, claim/TTL/duplicate-claim races are all synchronous in the worker event loop so they cannot interleave, and stale-key unregister is guarded by clientId compare. Pool export/seed counter bookkeeping mirrors release/reject correctly, and seed's prefix handling via prependTransport is right.

codinget pushed to main at webnet/webnet 2026-07-12 04:07:13 +02:00
d60c6d1736 docs: require labels on issues
codinget deleted branch docs/issue-label-guidance from webnet/webnet 2026-07-12 04:07:13 +02:00
codinget merged pull request webnet/webnet#95 2026-07-12 04:07:11 +02:00
Document labels for agent-opened issues